[TOOL-2815] Nebula - handle disconnected wallet state, use connected account address in execute config #5821

MananTank · 2024-12-20T14:18:19Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing user experience in the chat application by preventing default behavior on the Enter key, simplifying authentication logic, and introducing a modal dialog for wallet connection issues.

Detailed summary

Prevent default action on Enter key in ChatBar.
Remove unused getAuthTokenWalletAddress calls for account address retrieval.
Update promptNebula to handle config as nullable.
Introduce showConnectModal state for wallet connection prompts in ChatPageContent.
Add WalletDisconnectedDialog for handling wallet disconnection scenarios.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-20T14:18:22Z

TOOL-2815 Handle disconnected state in Nebula chat UI

changeset-bot · 2024-12-20T14:18:23Z

⚠️ No Changeset found

Latest commit: 36ae01a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-20T14:18:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 23, 2024 9:30pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 23, 2024 9:30pm
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 23, 2024 9:30pm
wallet-ui	⬜️ Skipped (Inspect)	Dec 23, 2024 9:30pm

MananTank · 2024-12-20T14:18:39Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-12-20T14:22:12Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.02 KB (0%)	901 ms (0%)	1.3 s (-0.9% 🔽)	2.2 s
thirdweb (cjs)	110.76 KB (0%)	2.3 s (0%)	2.8 s (+13.8% 🔺)	5 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	394 ms (+322.08% 🔺)	505 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	30 ms (-30.31% 🔽)	40 ms
thirdweb/react (minimal + tree-shaking)	19.1 KB (0%)	383 ms (0%)	325 ms (+1.89% 🔺)	707 ms

codecov · 2024-12-20T14:26:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (1b103d7) to head (1e27491).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5821   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files        1102     1102           
  Lines       59202    59202           
  Branches     4885     4885           
=======================================
  Hits        32037    32037           
  Misses      26441    26441           
  Partials      724      724

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 1b103d7
packages	`51.50% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-12-23T21:21:29Z

Merge activity

Dec 23, 4:21 PM EST: A user added this pull request to the Graphite merge queue.
Dec 23, 4:31 PM EST: A user merged this pull request with the Graphite merge queue.

…account address in execute config (#5821) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR primarily focuses on refining the chat functionality and user experience in the `ChatBar` and `ChatPageContent` components. It enhances wallet connection handling, streamlines message sending, and introduces a dialog for when the wallet is disconnected. ### Detailed summary - Added `e.preventDefault()` in `ChatBar` to prevent default behavior on Enter key. - Removed unused wallet address fetching in several components. - Updated `config` type to allow `null` in `Chat` API. - Introduced `WalletDisconnectedDialog` in `ChatPageContent`. - Enhanced state management for showing different login pages. - Improved context filter updates based on wallet address and active chain. - Added conditional rendering for wallet connection prompts. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 14:18 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 14:18 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 14:18 Inactive

MananTank marked this pull request as ready for review December 20, 2024 14:18

MananTank requested review from jakubkrehel and a team as code owners December 20, 2024 14:18

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 20, 2024

github-actions bot assigned MananTank Dec 20, 2024

vercel bot deployed to Preview – thirdweb-www December 20, 2024 14:28 View deployment

MananTank mentioned this pull request Dec 20, 2024

[TOOL-2816] Nebula - update sidebar + other minor UI adjustments #5823

Merged

jnsdls approved these changes Dec 20, 2024

View reviewed changes

MananTank force-pushed the 12-20-_tool-2815_nebula_-_handle_disconnected_wallet_state_use_connected_account_address_in_execute_config branch from 36ae01a to 1e27491 Compare December 23, 2024 21:21

vercel bot temporarily deployed to Preview – docs-v2 December 23, 2024 21:22 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 23, 2024 21:22 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 23, 2024 21:22 Inactive

vercel bot deployed to Preview – thirdweb-www December 23, 2024 21:30 View deployment

graphite-app bot merged commit 1e27491 into main Dec 23, 2024
32 checks passed

graphite-app bot deleted the 12-20-_tool-2815_nebula_-_handle_disconnected_wallet_state_use_connected_account_address_in_execute_config branch December 23, 2024 21:31

vercel bot temporarily deployed to Production – docs-v2 December 23, 2024 21:31 Inactive

vercel bot temporarily deployed to Production – wallet-ui December 23, 2024 21:31 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground December 23, 2024 21:31 Inactive

vercel bot deployed to Production – thirdweb-www December 23, 2024 21:40 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2815] Nebula - handle disconnected wallet state, use connected account address in execute config #5821

[TOOL-2815] Nebula - handle disconnected wallet state, use connected account address in execute config #5821

Uh oh!

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

changeset-bot bot commented Dec 20, 2024

Uh oh!

vercel bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

MananTank commented Dec 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[TOOL-2815] Nebula - handle disconnected wallet state, use connected account address in execute config #5821

[TOOL-2815] Nebula - handle disconnected wallet state, use connected account address in execute config #5821

Uh oh!

Conversation

MananTank commented Dec 20, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Uh oh!

vercel bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

MananTank commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 23, 2024 •

edited

Loading