Skip to content

[TOOL-2816] Nebula - update sidebar + other minor UI adjustments #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the UI components in the ChatBar, ChatSidebar, and ContextFilters by refining button styles, adjusting layout classes, and enhancing accessibility features. It also introduces new components and modifies existing ones for better consistency.

Detailed summary

  • Removed variant="primary" from Button in ChatBar.tsx.
  • Simplified Button usage in NebulaMobileNav.tsx.
  • Adjusted class names in ChatHistoryPage.tsx for better layout.
  • Added variant="secondary" to Badge components in ContextFilters.tsx.
  • Updated icons in ChatSidebar.tsx and changed button styles.
  • Introduced SidebarIconLink component for cleaner link rendering.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 20, 2024

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 30a580f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 9:30pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 23, 2024 9:30pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 23, 2024 9:30pm
wallet-ui ⬜️ Skipped (Inspect) Dec 23, 2024 9:30pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 15:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 15:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 15:55 Inactive
@MananTank MananTank marked this pull request as ready for review December 20, 2024 15:55
@MananTank MananTank requested review from jakubkrehel and a team as code owners December 20, 2024 15:55
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 20, 2024
Copy link
Member Author

MananTank commented Dec 20, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 12-20-_tool-2816_nebula_-_update_sidebar branch from c823375 to 30a580f Compare December 20, 2024 15:57
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 15:57 Inactive
@MananTank MananTank force-pushed the 12-20-_tool-2816_nebula_-_update_sidebar branch from 30a580f to d0a2a6c Compare December 20, 2024 15:59
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 15:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 15:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 15:59 Inactive
@MananTank MananTank changed the title [TOOL-2816] Nebula - update sidebar [TOOL-2816] Nebula - update sidebar + other minor UI adjustments Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 360 ms (+35.28% 🔺) 1.3 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 669 ms (-3.7% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 105 ms (+404.17% 🔺) 216 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+786.54% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (-0.08% 🔽) 383 ms (-0.08% 🔽) 188 ms (+129.63% 🔺) 570 ms

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (1e27491) to head (9bd9923).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5823   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files        1102     1102           
  Lines       59202    59202           
  Branches     4885     4885           
=======================================
  Hits        32037    32037           
  Misses      26441    26441           
  Partials      724      724           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1e27491
packages 51.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

graphite-app bot commented Dec 23, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the UI components in the `ChatBar`, `ChatSidebar`, and `ContextFilters` by updating styles, modifying button variants, and enhancing layout structures. It also introduces a new `SidebarIconLink` component for better organization.

### Detailed summary
- Removed `variant="primary"` from `Button` in `ChatBar`.
- Simplified `Button` in `NebulaMobileNav`.
- Adjusted class names in `ChatHistoryPage` for responsiveness.
- Updated `Badge` components in `ContextFilters` to use `variant="secondary"`.
- Replaced multiple icons in `ChatSidebar` with new ones.
- Changed `Button` variant to `outline` in `ChatSidebar`.
- Added new `SidebarIconLink` component for navigation links.
- Adjusted layout spacing in `ChatSidebar`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-20-_tool-2815_nebula_-_handle_disconnected_wallet_state_use_connected_account_address_in_execute_config branch from 36ae01a to 1e27491 Compare December 23, 2024 21:21
@MananTank MananTank force-pushed the 12-20-_tool-2816_nebula_-_update_sidebar branch from d0a2a6c to 9bd9923 Compare December 23, 2024 21:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 23, 2024 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 23, 2024 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 23, 2024 21:22 Inactive
Base automatically changed from 12-20-_tool-2815_nebula_-_handle_disconnected_wallet_state_use_connected_account_address_in_execute_config to main December 23, 2024 21:31
@graphite-app graphite-app bot merged commit 9bd9923 into main Dec 23, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-20-_tool-2816_nebula_-_update_sidebar branch December 23, 2024 21:32
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 23, 2024 21:32 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 23, 2024 21:32 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 23, 2024 21:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants