[TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases #5824

MananTank · 2024-12-20T19:07:18Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the date-utils function, updating component imports, and improving the SnapshotUpload and AirdropUpload components for better handling of data and user interactions.

Detailed summary

Updated toDateTimeLocal function to check for Date instance.
Replaced SnapshotUpload with SnapshotViewerSheet in the ClaimConditionsForm.
Enhanced AirdropUpload with loading state handling.
Improved useCsvUpload to use useQuery instead of useQueries.
Added Spinner for loading states in SnapshotUpload.
Revised data handling in SnapshotUpload and AirdropUpload components.
Updated requirements and error messages for CSV uploads.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-20T19:07:21Z

TOOL-2821 Improve performance of SnapshotUpload component and fix date rendering issue

vercel · 2024-12-20T19:07:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 7:29pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 7:29pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 7:29pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 7:29pm

changeset-bot · 2024-12-20T19:07:23Z

⚠️ No Changeset found

Latest commit: 243c497

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2024-12-20T19:07:44Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

socket-security · 2024-12-20T19:08:17Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/p-limit@6.2.0	None	`+1`	17.2 kB	sindresorhus

View full report↗︎

codecov · 2024-12-20T19:08:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (5f8e570) to head (243c497).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5824   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4825     4825           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 5f8e570
packages	`50.56% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-20T19:10:57Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.02 KB (0%)	901 ms (0%)	2.8 s (+2.06% 🔺)	3.7 s
thirdweb (cjs)	110.76 KB (0%)	2.3 s (0%)	5.7 s (-20.4% 🔽)	8 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	447 ms (+70.38% 🔺)	559 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	200 ms (+38.43% 🔺)	210 ms
thirdweb/react (minimal + tree-shaking)	19.1 KB (0%)	383 ms (0%)	482 ms (-43.16% 🔽)	865 ms

graphite-app · 2024-12-20T19:21:06Z

Merge activity

Dec 20, 2:21 PM EST: A user added this pull request to the Graphite merge queue.
Dec 20, 2:30 PM EST: A user merged this pull request with the Graphite merge queue.

…te not shown in phases (#5824) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the `date-utils` and `claim-conditions` components, updating the handling of date types, and refactoring the `SnapshotUpload` component to improve data processing and user experience. It also introduces a new dependency, `p-limit`, for better concurrency control. ### Detailed summary - Updated `toDateTimeLocal` function to handle `Date` instances directly. - Replaced `SnapshotUpload` with `SnapshotViewerSheet` in `claim-conditions-form`. - Enhanced `AirdropUpload` to show a loading spinner when data is being normalized. - Refactored `useCsvUpload` to use `useQuery` instead of `useQueries`. - Improved error handling and data validation in `SnapshotUpload`. - Added new dependency `p-limit` for managing concurrent requests. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

MananTank marked this pull request as ready for review December 20, 2024 19:07

MananTank requested review from jakubkrehel and a team as code owners December 20, 2024 19:07

github-actions bot assigned MananTank Dec 20, 2024

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 20, 2024

vercel bot deployed to Preview – wallet-ui December 20, 2024 19:08 View deployment

vercel bot deployed to Preview – thirdweb_playground December 20, 2024 19:08 View deployment

vercel bot deployed to Preview – docs-v2 December 20, 2024 19:09 View deployment

jnsdls approved these changes Dec 20, 2024

View reviewed changes

MananTank changed the title ~~[TOOL-2821] Improved performance of snapshot viewer component + fix date not shown in phases~~ [TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases Dec 20, 2024

vercel bot deployed to Preview – thirdweb-www December 20, 2024 19:18 View deployment

MananTank force-pushed the 12-21-_tool-2821_improved_performance_of_snapshot_viewer_component_fix_date_not_shown_in_phases branch from 370aa0a to 243c497 Compare December 20, 2024 19:21

vercel bot deployed to Preview – wallet-ui December 20, 2024 19:22 View deployment

vercel bot deployed to Preview – thirdweb_playground December 20, 2024 19:22 View deployment

vercel bot deployed to Preview – docs-v2 December 20, 2024 19:23 View deployment

vercel bot deployed to Preview – thirdweb-www December 20, 2024 19:29 View deployment

graphite-app bot merged commit 243c497 into main Dec 20, 2024
32 checks passed

graphite-app bot deleted the 12-21-_tool-2821_improved_performance_of_snapshot_viewer_component_fix_date_not_shown_in_phases branch December 20, 2024 19:30

vercel bot deployed to Production – wallet-ui December 20, 2024 19:31 View deployment

vercel bot deployed to Production – thirdweb_playground December 20, 2024 19:31 View deployment

vercel bot deployed to Production – docs-v2 December 20, 2024 19:32 View deployment

vercel bot deployed to Production – thirdweb-www December 20, 2024 19:39 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases #5824

[TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases #5824

Uh oh!

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

vercel bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

MananTank commented Dec 20, 2024

Uh oh!

socket-security bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases #5824

[TOOL-2821] Improve performance of snapshot viewer component + fix date not shown in phases #5824

Uh oh!

Conversation

MananTank commented Dec 20, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 20, 2024

Uh oh!

vercel bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Dec 20, 2024

How to use the Graphite Merge Queue

Uh oh!

socket-security bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Dec 20, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 20, 2024 •

edited

Loading

changeset-bot bot commented Dec 20, 2024 •

edited

Loading

socket-security bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

graphite-app bot commented Dec 20, 2024 •

edited

Loading