[SDK] Test coverage TOOL-2241 #5826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
changed the title
kien-ngo
added
the
DO NOT MERGE
Graphite App
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5826 +/- ##
==========================================
+ Coverage 54.52% 55.18% +0.66%
==========================================
Files 1105 1123 +18
Lines 59332 59611 +279
Branches 4921 5030 +109
==========================================
+ Hits 32349 32895 +546
+ Misses 26263 25996 -267
Partials 720 720
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
force-pushed
the
kien/react-code-coverage-2
branch
from
960599a to
9022cdd
Compare
kien-ngo
changed the title
kien-ngo
force-pushed
the
kien/react-code-coverage-2
branch
from
9022cdd to
46ad2f0
Compare
gregfromstl
approved these changes
Dec 23, 2024
kien-ngo
force-pushed
the
kien/react-code-coverage-2
branch
from
ae02146 to
7d7fec7
Compare
gregfromstl
added
merge-queue
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Dec 27, 2024
Holiday project.
Basically trying to improve test coverage, especially in those low-haning-fruit utils files
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing documentation, improving error handling, and adding tests across various modules in the codebase. It also corrects minor typos and ensures better code readability.
### Detailed summary
- Added `@internal` documentation comments to `Queue` and `convertViemChain`.
- Updated test cases to use `await expect(...)` for consistency.
- Fixed typos in file imports and function names.
- Introduced new tests for `namehash`, `encodeLabelhash`, and `parseNFT`.
- Enhanced error handling in `parseNftUri`.
- Improved the `toSemver` function and its tests.
- Added tests for `replaceBigInts` and `toHex` functions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/react-code-coverage-2
branch
from
7d7fec7 to
748edf9
Compare
graphite-app
bot
removed
the
merge-queue
Holiday project.
Basically trying to improve test coverage, especially in those low-haning-fruit utils files
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing documentation, improving error handling, and adding tests across various modules in the codebase. It also corrects minor typos and ensures better code readability.
### Detailed summary
- Added `@internal` documentation comments to `Queue` and `convertViemChain`.
- Updated test cases to use `await expect(...)` for consistency.
- Fixed typos in file imports and function names.
- Introduced new tests for `namehash`, `encodeLabelhash`, and `parseNFT`.
- Enhanced error handling in `parseNftUri`.
- Improved the `toSemver` function and its tests.
- Added tests for `replaceBigInts` and `toHex` functions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/react-code-coverage-2
branch
from
748edf9 to
03bf859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holiday project.
Basically trying to improve test coverage, especially in those low-haning-fruit utils files
PR-Codex overview
This PR primarily focuses on enhancing the codebase by adding internal documentation, improving error handling in various functions, and ensuring consistency in function exports. Additionally, it includes new test cases for several utility functions.
Detailed summary
@internalannotations toQueueandconvertViemChain.exportfor better visibility.await expect(...)for promise handling.namehash,encodeLabelhash, and other utility functions.parseNftUriandgetContract.isHttpUrl,formatUniversalUrl, andformatNativeUrlwith more test coverage.