[SDK] Feature: Adds getAdminAccount to ecosystem wallets and cleans up smart account creation
#5829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a47600a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5829 +/- ##
==========================================
+ Coverage 54.11% 55.29% +1.17%
==========================================
Files 1102 1123 +21
Lines 59202 59623 +421
Branches 4885 5042 +157
==========================================
+ Hits 32037 32966 +929
+ Misses 26441 25935 -506
+ Partials 724 722 -2
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Merge activity
|
jnsdls
approved these changes
Jan 4, 2025
gregfromstl
added a commit
that referenced
this pull request
Jan 4, 2025
… up smart account creation (#5829) Also Fixes TOOL-2833 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new method, `getAdminAccount`, to the `inAppWallet` interface, enhancing support for account abstraction (AA) wallets. It also refactors existing wallet connection methods to streamline interactions with smart accounts. ### Detailed summary - Added `getAdminAccount` method to `inAppWallet` interface. - Refactored wallet connection methods from `connectSmartWallet` to `connectSmartAccount`. - Updated tests to reflect new connection methods and account handling. - Enhanced logic to determine if an account is a smart account. - Improved error handling for personal account connections. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/tool-2832-add-getadminaccount-to-smart-ecosystem-wallets
branch
from
3a9fa64 to
ca3cbca
Compare
graphite-app
bot
removed
the
merge-queue
| @@ -46,6 +47,7 @@ export function createInAppWallet(args: { | |||
| const { createOptions: _createOptions, connectorFactory, ecosystem } = args; | |||
| const walletId = ecosystem ? ecosystem.id : "inApp"; | |||
| const emitter = createWalletEmitter<"inApp">(); | |||
| let isSmartWallet = false; | |||
| return undefined; | ||
| } else { | ||
| // This might return an admin account (if the main account is a smart account), otherwise it'll return undefined | ||
| return getAdminAccountForSmartAccount(account); |
There was a problem hiding this comment.
How about we just store the admin account the same way we store the active account?
Would rather not rely on an in-memory map if possible.
That way you don't need the boolean flag either, just keep both accounts around
There was a problem hiding this comment.
Nice, I like that much better
gregfromstl
force-pushed
the
greg/tool-2832-add-getadminaccount-to-smart-ecosystem-wallets
branch
2 times, most recently
from
3a9fa64 to
db093ab
Compare
gregfromstl
force-pushed
the
greg/tool-2832-add-getadminaccount-to-smart-ecosystem-wallets
branch
from
db093ab to
a47600a
Compare
gregfromstl
deleted the
greg/tool-2832-add-getadminaccount-to-smart-ecosystem-wallets
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Fixes TOOL-2833
PR-Codex overview
This PR introduces the
getAdminAccountmethod to theinAppWalletinterface, enhancing the functionality for Account Abstraction (AA) ecosystem wallets. It also refines wallet connection and disconnection processes, improving the overall wallet management experience.Detailed summary
getAdminAccountmethod toinAppWallet.smartWalletto includegetAdminAccountand refactored connection methods.connectSmartWalletwithconnectSmartAccountacross various files.