-
Notifications
You must be signed in to change notification settings - Fork 538
Add onramp providers page to Pay overview #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You must have Developer access to commit code to thirdweb on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
icon: "thirdweb", | ||
}, | ||
title: "thirdweb Pay - Onramp Providers | thirdweb", | ||
description: ".", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata description
field contains only a period. Consider adding a descriptive summary of the onramp providers page that explains its purpose and content, which will improve SEO and provide better context in search results and link previews.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5836 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 1145 1145
Lines 60996 60996
Branches 5156 5156
=======================================
Hits 33528 33528
Misses 26740 26740
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
|
||
## Choosing a Preferred Provider | ||
|
||
It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relative path ../pay/customization/connectbutton#preferredProvider
needs to be updated to ../customization/connectbutton#preferred-provider
. The anchor portion of the URL should use kebab-case to match the auto-generated heading ID from the markdown processor.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d084fdf
to
18d0a22
Compare
Merge activity
|
Added onramp page and preferredPartner information to customization pages <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces new features related to onramp providers, allowing users to specify preferred providers and updates documentation across several pages to reflect these changes. ### Detailed summary - Added `Onramp Providers` section in `sidebar.tsx`. - Introduced a `Preferred Provider` section in `payembed/page.mdx` and `connectbutton/page.mdx`. - Created a new `onramp-providers/page.mdx` with details on available providers. - Updated `send-transaction/page.mdx` to include `preferredProvider` options. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
18d0a22
to
10d4b24
Compare
Added onramp page and preferredPartner information to customization pages <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on adding support for specifying preferred onramp providers in various components and updating documentation accordingly. ### Detailed summary - Added `Onramp Providers` option in the sidebar. - Introduced `Preferred Provider` section in `payembed` and `connectbutton` documentation. - Created a new `onramp-providers` page detailing supported providers and how to set a preferred provider. - Updated `send-transaction` documentation to include `preferredProvider` parameter. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
10d4b24
to
46bf17c
Compare
Added onramp page and preferredPartner information to customization pages
PR-Codex overview
This PR enhances the onramp provider functionality in the
thirdweb
Pay integration by adding the ability to specify preferred providers and updating documentation to reflect these changes.Detailed summary
sidebar.tsx
.Preferred Provider
documentation inpage.mdx
forPayEmbed
andConnectButton
.onramp-providers
page with provider details and supported countries.send-transaction
documentation to includepreferredProvider
parameter.