Skip to content

Add onramp providers page to Pay overview #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

ianthirdweb
Copy link
Contributor

@ianthirdweb ianthirdweb commented Dec 24, 2024

Added onramp page and preferredPartner information to customization pages


PR-Codex overview

This PR enhances the onramp provider functionality in the thirdweb Pay integration by adding the ability to specify preferred providers and updating documentation to reflect these changes.

Detailed summary

  • Added "Onramp Providers" section in sidebar.tsx.
  • Introduced Preferred Provider documentation in page.mdx for PayEmbed and ConnectButton.
  • Created a new onramp-providers page with provider details and supported countries.
  • Updated send-transaction documentation to include preferredProvider parameter.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@ianthirdweb ianthirdweb requested review from jakubkrehel and a team as code owners December 24, 2024 15:35
Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 46bf17c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 24, 2024

You must have Developer access to commit code to thirdweb on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link
Contributor

graphite-app bot commented Dec 24, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 24, 2024
icon: "thirdweb",
},
title: "thirdweb Pay - Onramp Providers | thirdweb",
description: ".",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata description field contains only a period. Consider adding a descriptive summary of the onramp providers page that explains its purpose and content, which will improve SEO and provide better context in search results and link previews.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (a6fe226) to head (46bf17c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5836   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files        1145     1145           
  Lines       60996    60996           
  Branches     5156     5156           
=======================================
  Hits        33528    33528           
  Misses      26740    26740           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a6fe226
packages 52.64% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


## Choosing a Preferred Provider

It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative path ../pay/customization/connectbutton#preferredProvider needs to be updated to ../customization/connectbutton#preferred-provider. The anchor portion of the URL should use kebab-case to match the auto-generated heading ID from the markdown processor.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

github-actions bot commented Dec 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (-0.02% 🔽) 934 ms (-0.02% 🔽) 369 ms (+5.76% 🔺) 1.4 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 620 ms (-0.61% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 110 ms (+437.21% 🔺) 222 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+538.33% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 286 ms (+176.9% 🔺) 670 ms

Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 7:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 14, 2025 7:50pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 14, 2025 7:50pm
wallet-ui ⬜️ Skipped (Inspect) Jan 14, 2025 7:50pm

Copy link
Member

gregfromstl commented Jan 7, 2025

Merge activity

  • Jan 6, 9:24 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 9:24 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 9:27 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
  • Jan 14, 2:39 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 2:42 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 14, 2:51 PM EST: A user merged this pull request with the Graphite merge queue.

gregfromstl pushed a commit that referenced this pull request Jan 7, 2025
Added onramp page and preferredPartner information to customization pages

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces new features related to onramp providers, allowing users to specify preferred providers and updates documentation across several pages to reflect these changes.

### Detailed summary
- Added `Onramp Providers` section in `sidebar.tsx`.
- Introduced a `Preferred Provider` section in `payembed/page.mdx` and `connectbutton/page.mdx`.
- Created a new `onramp-providers/page.mdx` with details on available providers.
- Updated `send-transaction/page.mdx` to include `preferredProvider` options.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 7, 2025 02:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 7, 2025 02:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 7, 2025 02:24 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 7, 2025
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 14, 2025
Added onramp page and preferredPartner information to customization pages

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding support for specifying preferred onramp providers in various components and updating documentation accordingly.

### Detailed summary
- Added `Onramp Providers` option in the sidebar.
- Introduced `Preferred Provider` section in `payembed` and `connectbutton` documentation.
- Created a new `onramp-providers` page detailing supported providers and how to set a preferred provider.
- Updated `send-transaction` documentation to include `preferredProvider` parameter.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 14, 2025 19:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 19:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 19:42 Inactive
@graphite-app graphite-app bot merged commit 46bf17c into main Jan 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the ian/pay-onramps branch January 14, 2025 19:51
@vercel vercel bot temporarily deployed to Production – wallet-ui January 14, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www January 14, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 14, 2025 19:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants