Skip to content

Update implementations #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Update implementations #5837

merged 1 commit into from
Dec 24, 2024

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Dec 24, 2024

TOOL-2834

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the contract implementations for the MarketplaceV3 and ZKSYNC_WETH in the thirdweb package to include new addresses for the 37111 network.

Detailed summary

  • Added MarketplaceV3 address for network 37111: 0x56Abb6a3f25DCcdaDa106191053b1CC54C196DEE.
  • Added ZKSYNC_WETH address for network 37111: 0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners December 24, 2024 17:42
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:14pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:14pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:14pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:14pm

Copy link
Contributor

graphite-app bot commented Dec 24, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 24, 2024
@kumaryash90 kumaryash90 added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Dec 24, 2024
Copy link
Member Author

kumaryash90 commented Dec 24, 2024

Merge activity

  • Dec 24, 12:42 PM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 24, 1:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 24, 1:14 PM EST: A user merged this pull request with the Graphite merge queue.

Copy link
Contributor

github-actions bot commented Dec 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 822 ms (+32.12% 🔺) 1.8 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.5 s (-26.1% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 114 ms (+62.26% 🔺) 226 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 35 ms (-0.95% 🔽) 45 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 259 ms (+28.17% 🔺) 641 ms

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (d2af09c) to head (ce3e850).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5837      +/-   ##
==========================================
- Coverage   54.12%   54.12%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       59202    59206       +4     
  Branches     4885     4886       +1     
==========================================
- Hits        32045    32044       -1     
- Misses      26433    26438       +5     
  Partials      724      724              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d2af09c
packages 51.51% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../src/contract/deployment/zksync/implementations.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

kumaryash90 added a commit that referenced this pull request Dec 24, 2024
TOOL-2834
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `MarketplaceV3` and `ZKSYNC_WETH` records by adding new entries for the blockchain network identified by the number `37111`.

### Detailed summary
- Added a new entry for `MarketplaceV3` with the address `0x56Abb6a3f25DCcdaDa106191053b1CC54C196DEE` under the key `37111`.
- Added a new entry for `ZKSYNC_WETH` with the address `0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16` under the key `37111`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kumaryash90 kumaryash90 force-pushed the yash/update-implementations branch from e21bb34 to ce26d49 Compare December 24, 2024 18:07
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: ce3e850

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TOOL-2834
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `implementations.ts` file for the `thirdweb` package to include new marketplace and WETH addresses for the `ZKSYNC` network.

### Detailed summary
- Added a new marketplace address for `37111` in the `MarketplaceV3` object.
- Added a new WETH address for `37111` in the `ZKSYNC_WETH` object.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants