[SDK] Fix: allow 0 values for gasPrice #5841

d4mr · 2024-12-26T19:05:54Z

Problem solved

Allow 0 value for gasPrice, important for gasless chains
Fixes TOOL-2865

PR-Codex overview

This PR updates the conditional check for gasPrice in the fee-data.ts file to ensure it specifically checks if gasPrice is of type bigint, enhancing type safety.

Detailed summary

Changed the condition from if (gasPrice) to if (typeof gasPrice === "bigint") in the fee-data.ts file.
This modification ensures that the subsequent code block only executes when gasPrice is a bigint.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-12-26T19:05:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 8:08pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 8:08pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 8:08pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 8:08pm

changeset-bot · 2024-12-26T19:05:58Z

⚠️ No Changeset found

Latest commit: 71eaf8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-12-26T19:06:00Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2024-12-26T19:09:19Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.07 KB (+0.1% 🔺)	902 ms (+0.1% 🔺)	345 ms (+58.5% 🔺)	1.3 s
thirdweb (cjs)	110.94 KB (+0.16% 🔺)	2.3 s (+0.16% 🔺)	591 ms (-8.97% 🔽)	2.9 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	150 ms (+346.31% 🔺)	262 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	37 ms (+336.78% 🔺)	47 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	179 ms (+147.98% 🔺)	562 ms

codecov · 2024-12-26T19:11:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (1556615) to head (71eaf8f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5841      +/-   ##
==========================================
- Coverage   54.53%   54.52%   -0.01%     
==========================================
  Files        1105     1105              
  Lines       59332    59332              
  Branches     4924     4921       -3     
==========================================
- Hits        32354    32349       -5     
- Misses      26258    26263       +5     
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 1556615
packages	`52.01% <100.00%> (-0.02%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/gas/fee-data.ts	`72.41% <100.00%> (ø)`

... and 2 files with indirect coverage changes

linear · 2024-12-27T19:56:01Z

TOOL-2865 SDK: 0 gasPrice

gregfromstl · 2024-12-27T19:59:56Z

Merge activity

Dec 27, 2:59 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 27, 2:59 PM EST: A user added this pull request to the Graphite merge queue.
Dec 27, 3:08 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Allow `0` value for gasPrice, important for gasless chains Fixes TOOL-2865  --- ## PR-Codex overview This PR modifies the conditional check for `gasPrice` in the `fee-data.ts` file to ensure it specifically checks if `gasPrice` is of type `bigint` instead of just checking its truthiness. ### Detailed summary - Changed the condition from `if (gasPrice)` to `if (typeof gasPrice === "bigint")` in the `fee-data.ts` file. - This ensures that only values of type `bigint` are considered valid for `gasPrice`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

d4mr requested review from a team as code owners December 26, 2024 19:05

github-actions bot assigned d4mr Dec 26, 2024

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 26, 2024

vercel bot deployed to Preview – wallet-ui December 26, 2024 19:07 View deployment

vercel bot deployed to Preview – thirdweb_playground December 26, 2024 19:08 View deployment

vercel bot deployed to Preview – docs-v2 December 26, 2024 19:12 View deployment

vercel bot deployed to Preview – thirdweb-www December 26, 2024 19:15 View deployment

jnsdls approved these changes Dec 26, 2024

View reviewed changes

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 27, 2024

gregfromstl force-pushed the pb/fix-zero-gas-price branch from 8730dfb to 71eaf8f Compare December 27, 2024 20:00

vercel bot deployed to Preview – thirdweb_playground December 27, 2024 20:01 View deployment

vercel bot deployed to Preview – wallet-ui December 27, 2024 20:01 View deployment

vercel bot deployed to Preview – thirdweb-www December 27, 2024 20:03 View deployment

vercel bot deployed to Preview – docs-v2 December 27, 2024 20:08 View deployment

graphite-app bot merged commit 71eaf8f into main Dec 27, 2024
32 checks passed

graphite-app bot deleted the pb/fix-zero-gas-price branch December 27, 2024 20:08

vercel bot deployed to Production – wallet-ui December 27, 2024 20:10 View deployment

vercel bot deployed to Production – docs-v2 December 27, 2024 20:10 View deployment

vercel bot deployed to Production – thirdweb_playground December 27, 2024 20:10 View deployment

vercel bot deployed to Production – thirdweb-www December 27, 2024 20:16 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix: allow 0 values for gasPrice #5841

[SDK] Fix: allow 0 values for gasPrice #5841

Uh oh!

d4mr commented Dec 26, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Dec 26, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 26, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 26, 2024

Uh oh!

github-actions bot commented Dec 26, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 26, 2024 •

edited

Loading

Uh oh!

linear bot commented Dec 27, 2024

Uh oh!

gregfromstl commented Dec 27, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

[SDK] Fix: allow 0 values for gasPrice #5841

[SDK] Fix: allow 0 values for gasPrice #5841

Uh oh!

Conversation

d4mr commented Dec 26, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Dec 26, 2024

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linear bot commented Dec 27, 2024

Uh oh!

gregfromstl commented Dec 27, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

d4mr commented Dec 26, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 26, 2024 •

edited

Loading

changeset-bot bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

codecov bot commented Dec 26, 2024 •

edited

Loading

gregfromstl commented Dec 27, 2024 •

edited by graphite-app bot

Loading