Skip to content

[Docs] .NET 2.10.0+ #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2024
Merged

[Docs] .NET 2.10.0+ #5842

merged 1 commit into from
Dec 26, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 26, 2024 •
edited by pr-codex bot
Loading

Closes TOOL-2440

PR-Codex overview

This PR focuses on simplifying contract interactions by removing the ThirdwebContract prefix in several instances, enhancing the clarity of the code. It also adds new functionalities related to unlinking accounts and introduces new metadata for wallet actions.

Detailed summary

  • Removed ThirdwebContract prefix from contract method calls in multiple files.
  • Added PurchaseData object in various payment-related methods.
  • Introduced unlinking account functionality in wallet management.
  • Added metadata for GetUserAuthDetails and SignAuthorization methods.
  • Updated documentation to clarify SDK usage and links.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper added merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase. labels Dec 26, 2024
@0xFirekeeper 0xFirekeeper requested review from jakubkrehel and a team as code owners December 26, 2024 19:39
@linear Linear
Copy link

linear bot commented Dec 26, 2024

TOOL-2440 .NET 2.10.0+ Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7293dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 7:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 26, 2024 7:51pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 26, 2024 7:51pm
wallet-ui ⬜️ Skipped (Inspect) Dec 26, 2024 7:51pm

@0xFirekeeper Graphite App
Copy link
Member Author

0xFirekeeper commented Dec 26, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 26, 2:40 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 26, 2:49 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 26, 2:52 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 26, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.53%. Comparing base (e9c23ad) to head (7293dfa).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5842   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files        1105     1105           
  Lines       59332    59332           
  Branches     4924     4924           
=======================================
  Hits        32354    32354           
  Misses      26258    26258           
  Partials      720      720
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e9c23ad
packages 52.02% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 2.8 s (-24.31% 🔽) 3.7 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 7.3 s (+9.78% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 232 ms (-4.76% 🔽) 344 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 83 ms (+63.34% 🔺) 93 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 679 ms (+85.75% 🔺) 1.1 s

@0xFirekeeper
[Docs] .NET 2.10.0+ (#5842)
7293dfa 
Closes TOOL-2440

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on refactoring the code to streamline interactions with contracts by removing references to `ThirdwebContract` and directly using `contract`. Additionally, it introduces new functionalities for unlinking accounts and enhances documentation across various pages.

### Detailed summary
- Refactored contract interactions to use `contract` instead of `ThirdwebContract`.
- Added `PurchaseData` object in `getbuywithfiatstatus` and `getbuywithfiatquote`.
- Introduced unlinking functionality in in-app and ecosystem wallets.
- Updated documentation for `SwitchNetwork` and `SignAuthorization`.
- Improved descriptions and metadata for various pages.
- Enhanced code examples and clarified usage instructions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@0xFirekeeper 0xFirekeeper force-pushed the firekeeper/docs-2.10.0 branch from 6bb6b6d to 7293dfa Compare December 26, 2024 19:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 26, 2024 19:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 26, 2024 19:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 26, 2024 19:49 Inactive
@graphite-app graphite-app bot merged commit 7293dfa into main Dec 26, 2024
31 checks passed
@graphite-app graphite-app bot deleted the firekeeper/docs-2.10.0 branch December 26, 2024 19:52
@vercel vercel bot temporarily deployed to Production – wallet-ui December 26, 2024 19:52 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 26, 2024 19:52 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 26, 2024 19:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregfromstl gregfromstl gregfromstl approved these changes

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

Assignees

@0xFirekeeper 0xFirekeeper

Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xFirekeeper @gregfromstl