[SDK] Fix: Use transaction-specified chain in smart account #5865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a9547c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
jnsdls
approved these changes
Dec 31, 2024
size-limit report 📦
|
gregfromstl
force-pushed
the
greg/tool-2888-sdk-switch-to-correct-chain-for-smart-account-transaction
branch
from
1418a39 to
3c803e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5865 +/- ##
=======================================
Coverage 55.18% 55.19%
=======================================
Files 1123 1123
Lines 59611 59622 +11
Branches 5031 5029 -2
=======================================
+ Hits 32895 32906 +11
Misses 25996 25996
Partials 720 720
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
force-pushed
the
greg/tool-2888-sdk-switch-to-correct-chain-for-smart-account-transaction
branch
from
3c803e8 to
76ca41d
Compare
gregfromstl
added
the
merge-queue
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on fixing chain switching in smart account transactions within the `thirdweb` SDK and adding tests for sending transactions across different chains.
### Detailed summary
- Updated the logic for `accountContract` in `packages/thirdweb/src/wallets/smart/index.ts` to handle chain switching.
- Added a new test in `packages/thirdweb/src/wallets/smart/smart-wallet-integration.test.ts` to verify sending transactions on another chain.
- Introduced similar test functionality in `packages/thirdweb/src/wallets/smart/smart-wallet-integration-v07.test.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/tool-2888-sdk-switch-to-correct-chain-for-smart-account-transaction
branch
from
76ca41d to
a9547c5
Compare
graphite-app
bot
deleted the
greg/tool-2888-sdk-switch-to-correct-chain-for-smart-account-transaction
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on fixing chain switching in smart account transactions, allowing transactions to be executed on different chains. It also adds tests to ensure this functionality works as expected.
Detailed summary
accountContracttoaccountContractForTransactionfor chain-specific transactions.smart-wallet-integration.test.ts.smart-wallet-integration-v07.test.tsfor consistency.