[TOOL-2891] Fix Team dashboard not loading if team slug contains special characters #5867

MananTank · 2025-01-01T15:08:40Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on improving the handling of team slugs in the application by decoding the slug from the URL and enhancing user feedback during team URL updates.

Detailed summary

Updated team retrieval to use decodeURIComponent for params.team_slug.
Updated project retrieval to use decodeURIComponent for params.team_slug.
Replaced isTeamTaken state with errorMessage for better error handling.
Added validation for team URL input, providing specific error messages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-01-01T15:08:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 1, 2025 5:05pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jan 1, 2025 5:05pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 1, 2025 5:05pm
wallet-ui	⬜️ Skipped (Inspect)	Jan 1, 2025 5:05pm

linear · 2025-01-01T15:08:42Z

TOOL-2891 Broken dashboard team url

changeset-bot · 2025-01-01T15:08:43Z

⚠️ No Changeset found

Latest commit: 8b1a60d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2025-01-01T15:08:57Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-01-01T15:10:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (8136ec9) to head (8b1a60d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5867   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5031           
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 8136ec9
packages	`52.83% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2025-01-01T15:12:19Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.09 KB (0%)	902 ms (0%)	2.4 s (-21.89% 🔽)	3.3 s
thirdweb (cjs)	110.84 KB (0%)	2.3 s (0%)	6.3 s (-1.47% 🔽)	8.6 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	546 ms (-7.5% 🔽)	658 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	102 ms (+85.93% 🔺)	112 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	666 ms (-13.47% 🔽)	1.1 s

graphite-app · 2025-01-01T17:01:33Z

Merge activity

Jan 1, 12:01 PM EST: A user added this pull request to the Graphite merge queue.
Jan 1, 12:06 PM EST: A user merged this pull request with the Graphite merge queue.

…ial characters (#5867) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on improving the handling of `team_slug` and validating the `teamSlug` input in the settings UI. It enhances the URL decoding process and adds error handling for invalid team URLs. ### Detailed summary - Updated `team_slug` retrieval to decode the URL component in `layout.tsx`. - Modified project retrieval logic to decode `team_slug`. - Replaced `isTeamTaken` state with `errorMessage` state for better error handling. - Added validation for `teamSlug` input to check for empty values and invalid characters. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – docs-v2 January 1, 2025 15:08 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 1, 2025 15:08 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 1, 2025 15:08 Inactive

MananTank marked this pull request as ready for review January 1, 2025 15:08

MananTank requested review from jakubkrehel and a team as code owners January 1, 2025 15:08

github-actions bot assigned MananTank Jan 1, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 1, 2025

MananTank force-pushed the 01-01-_tool-2891_fix_team_dashboard_not_loading_if_team_slug_contains_special_characters branch from e636ded to 489ba7c Compare January 1, 2025 15:13

vercel bot temporarily deployed to Preview – docs-v2 January 1, 2025 15:13 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 1, 2025 15:13 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 1, 2025 15:13 Inactive

MananTank force-pushed the 01-01-_tool-2891_fix_team_dashboard_not_loading_if_team_slug_contains_special_characters branch from 489ba7c to 945b0d1 Compare January 1, 2025 15:20

vercel bot temporarily deployed to Preview – thirdweb_playground January 1, 2025 15:21 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 1, 2025 15:21 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 1, 2025 15:21 Inactive

vercel bot deployed to Preview – thirdweb-www January 1, 2025 15:32 View deployment

jnsdls approved these changes Jan 1, 2025

View reviewed changes

MananTank force-pushed the 01-01-_tool-2891_fix_team_dashboard_not_loading_if_team_slug_contains_special_characters branch from 945b0d1 to 8b1a60d Compare January 1, 2025 17:02

vercel bot temporarily deployed to Preview – wallet-ui January 1, 2025 17:02 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 1, 2025 17:02 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 1, 2025 17:02 Inactive

vercel bot deployed to Preview – thirdweb-www January 1, 2025 17:05 View deployment

graphite-app bot merged commit 8b1a60d into main Jan 1, 2025
31 checks passed

graphite-app bot deleted the 01-01-_tool-2891_fix_team_dashboard_not_loading_if_team_slug_contains_special_characters branch January 1, 2025 17:06

vercel bot temporarily deployed to Production – wallet-ui January 1, 2025 17:06 Inactive

vercel bot temporarily deployed to Production – docs-v2 January 1, 2025 17:06 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground January 1, 2025 17:06 Inactive

vercel bot deployed to Production – thirdweb-www January 1, 2025 17:13 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2891] Fix Team dashboard not loading if team slug contains special characters #5867

[TOOL-2891] Fix Team dashboard not loading if team slug contains special characters #5867

Uh oh!

MananTank commented Jan 1, 2025 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

linear bot commented Jan 1, 2025

Uh oh!

changeset-bot bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

MananTank commented Jan 1, 2025

Uh oh!

codecov bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[TOOL-2891] Fix Team dashboard not loading if team slug contains special characters #5867

[TOOL-2891] Fix Team dashboard not loading if team slug contains special characters #5867

Uh oh!

Conversation

MananTank commented Jan 1, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jan 1, 2025

Uh oh!

changeset-bot bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Jan 1, 2025

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Jan 1, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 1, 2025 •

edited

Loading

changeset-bot bot commented Jan 1, 2025 •

edited

Loading

codecov bot commented Jan 1, 2025 •

edited

Loading

github-actions bot commented Jan 1, 2025 •

edited

Loading

graphite-app bot commented Jan 1, 2025 •

edited

Loading