Skip to content

TOOL-2831 - Update docs for showTestnetFaucet #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Jan 1, 2025

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the ConnectButtonProps to enhance the ConnectButton Details Modal by introducing a link for requesting testnet funds when connected to a testnet. It clarifies the conditions under which this link will appear.

Detailed summary

  • Added a note that the "Request Testnet funds" link will only show if faucet links are registered with the chain.
  • Updated the example for using ConnectButton to include the detailsModal prop for showing the testnet faucet link.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 1, 2025

Copy link

changeset-bot bot commented Jan 1, 2025

⚠️ No Changeset found

Latest commit: 74b489a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 4:14pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 4:14pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 4:14pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 4:14pm

@kien-ngo kien-ngo marked this pull request as ready for review January 1, 2025 16:04
@kien-ngo kien-ngo requested review from a team as code owners January 1, 2025 16:04
Copy link
Contributor Author

kien-ngo commented Jan 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 2.8 s (-26.01% 🔽) 3.7 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 6.7 s (+14.4% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 325 ms (-9.35% 🔽) 436 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 92 ms (-43.42% 🔽) 102 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 527 ms (+3.16% 🔺) 910 ms

@gregfromstl gregfromstl merged commit 3b1ed73 into main Jan 3, 2025
31 of 32 checks passed
@gregfromstl gregfromstl deleted the kien/TOOL-2831 branch January 3, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants