Skip to content

[SDK] Fix: Remove co.lobstr (not EVM compatible) #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jan 1, 2025

PR-Codex overview

This PR focuses on updating wallet configurations in the thirdweb package, including the removal of unsupported wallets, updating wallet details, and adding new wallet entries.

Detailed summary

  • Removed co.lobstr from available wallets.
  • Updated wallet details for several wallets (e.g., Coinomi, MetaMask, Ledger Live).
  • Added new wallets: BeraSig, PortaWallet, Family, SheFi, NonBank, Talisman Wallet, Alephium Wallet, UniversalProfiles, OverFlex, WEMIX Play, TobeWallet, Walletverse, clear-wallet, SafeWallet, LegionNetwork, Ctrl Wallet, Koala Wallet.
  • Updated image IDs and homepages for existing wallets.
  • Adjusted mobile deep links and app URLs for several wallets.

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet/io.universaleverything/image.ts, packages/thirdweb/src/wallets/__generated__/wallet-ids.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.huddln/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/global.safe/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/pro.tokenpocket/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.noone/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitnovo/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.berasig/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.safepal/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/network.over/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/finance.porta/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.roninchain.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/inc.tomo/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.trustwallet.app/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.safecryptowallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.walletconnect.com/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/eu.flashsoft.clear-wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/xyz.talisman/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.metamask/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/id.competence/image.ts, packages/thirdweb/src/react/web/ui/prebuilt/Wallet/icon.test.tsx, packages/thirdweb/src/wallets/__generated__/wallet/com.crypto.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.binance/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.leapwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet-infos.ts, packages/thirdweb/src/wallets/__generated__/wallet/im.token/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/app.keplr/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/org.uniswap/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bybit/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/network.mrhb/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.internetmoney/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.1inch.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/xyz.bonuz/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/ag.jup/image.ts, packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.moonstake/image.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from jnsdls, joaquim-verges and a team as code owners January 1, 2025 23:37
Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 0:20am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 0:20am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 0:20am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 0:20am

Copy link

linear bot commented Jan 1, 2025

Copy link

changeset-bot bot commented Jan 1, 2025

🦋 Changeset detected

Latest commit: 35279f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Jan 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45 KB (0%) 900 ms (0%) 3 s (+24.4% 🔺) 3.9 s
thirdweb (cjs) 110.81 KB (0%) 2.3 s (0%) 7.2 s (+48.68% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 213 ms (-51.5% 🔽) 324 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 142 ms (+12.93% 🔺) 152 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 615 ms (-36.9% 🔽) 998 ms

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (8b1a60d) to head (8e235ce).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5869   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5029    -2     
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8b1a60d
packages 52.83% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

@kien-ngo kien-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 3, 2025
Copy link
Member Author

gregfromstl commented Jan 3, 2025

Merge activity

  • Jan 3, 5:35 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 3, 5:35 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 3, 5:50 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
  • Jan 3, 5:51 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 3, 10:51 PM UTC: The merge label 'merge-queue' was removed. This PR will no longer be merged by the Graphite merge queue

<!-- start pr-codex -->

## PR-Codex overview
This PR primarily focuses on updating the wallet configurations in the `thirdweb` SDK. It removes unsupported wallets, updates wallet details, and adds new wallet entries with accurate metadata.

### Detailed summary
- Removed `co.lobstr` wallet due to non-EVM compatibility.
- Updated `image_id` and `homepage` for several wallets including `Coinomi`, `MetaMask`, and `Ledger Live`.
- Added new wallet entries: `BeraSig`, `PortaWallet`, `Family`, `SheFi`, and others.
- Updated deep link and mobile configurations for various wallets.
- Changed `rdns` values for specific wallets to reflect new identifiers.

> The following files were skipped due to too many changes: `packages/thirdweb/src/wallets/__generated__/wallet/io.universaleverything/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-ids.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.huddln/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/global.safe/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/pro.tokenpocket/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.noone/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitnovo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.berasig/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.safepal/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.over/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/finance.porta/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.roninchain.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/inc.tomo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.trustwallet.app/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.safecryptowallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.walletconnect.com/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/eu.flashsoft.clear-wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.talisman/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.metamask/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/id.competence/image.ts`, `packages/thirdweb/src/react/web/ui/prebuilt/Wallet/icon.test.tsx`, `packages/thirdweb/src/wallets/__generated__/wallet/com.crypto.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.binance/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.leapwallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-infos.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/im.token/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/app.keplr/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/org.uniswap/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bybit/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.mrhb/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.internetmoney/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.1inch.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.bonuz/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/ag.jup/image.ts`, `packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.moonstake/image.ts`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/tool-2887-remove-lobstr-from-available-wallets branch from 8e235ce to 35279f8 Compare January 3, 2025 22:48
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 3, 2025
@gregfromstl gregfromstl merged commit 273a320 into main Jan 4, 2025
28 of 29 checks passed
@gregfromstl gregfromstl deleted the greg/tool-2887-remove-lobstr-from-available-wallets branch January 4, 2025 00:26
@jnsdls jnsdls mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants