-
Notifications
You must be signed in to change notification settings - Fork 544
[SDK] Fix: Remove co.lobstr (not EVM compatible) #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Remove co.lobstr (not EVM compatible) #5869
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 35279f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
bfb4492
to
8e235ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5869 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 1123 1123
Lines 59611 59611
Branches 5031 5029 -2
=======================================
Hits 32895 32895
Misses 25996 25996
Partials 720 720
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merge activity
|
<!-- start pr-codex --> ## PR-Codex overview This PR primarily focuses on updating the wallet configurations in the `thirdweb` SDK. It removes unsupported wallets, updates wallet details, and adds new wallet entries with accurate metadata. ### Detailed summary - Removed `co.lobstr` wallet due to non-EVM compatibility. - Updated `image_id` and `homepage` for several wallets including `Coinomi`, `MetaMask`, and `Ledger Live`. - Added new wallet entries: `BeraSig`, `PortaWallet`, `Family`, `SheFi`, and others. - Updated deep link and mobile configurations for various wallets. - Changed `rdns` values for specific wallets to reflect new identifiers. > The following files were skipped due to too many changes: `packages/thirdweb/src/wallets/__generated__/wallet/io.universaleverything/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-ids.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.huddln/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/global.safe/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/pro.tokenpocket/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.noone/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitnovo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.berasig/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.safepal/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.over/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/finance.porta/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.roninchain.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/inc.tomo/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.trustwallet.app/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.safecryptowallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.walletconnect.com/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/eu.flashsoft.clear-wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.talisman/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.metamask/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/id.competence/image.ts`, `packages/thirdweb/src/react/web/ui/prebuilt/Wallet/icon.test.tsx`, `packages/thirdweb/src/wallets/__generated__/wallet/com.crypto.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.binance/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.leapwallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet-infos.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/im.token/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/app.keplr/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/org.uniswap/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bybit/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/network.mrhb/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.internetmoney/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.1inch.wallet/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/xyz.bonuz/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/ag.jup/image.ts`, `packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/io.moonstake/image.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
8e235ce
to
35279f8
Compare
PR-Codex overview
This PR focuses on updating wallet configurations in the
thirdweb
package, including the removal of unsupported wallets, updating wallet details, and adding new wallet entries.Detailed summary
co.lobstr
from available wallets.Coinomi
,MetaMask
,Ledger Live
).BeraSig
,PortaWallet
,Family
,SheFi
,NonBank
,Talisman Wallet
,Alephium Wallet
,UniversalProfiles
,OverFlex
,WEMIX Play
,TobeWallet
,Walletverse
,clear-wallet
,SafeWallet
,LegionNetwork
,Ctrl Wallet
,Koala Wallet
.