Skip to content

[CI] Fix: Run auto-assign check if user is a prev contributor #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jan 2, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR updates the auto-assign.yml workflow to modify the conditions under which a pull request author is automatically assigned. It adds the CONTRIBUTOR association type to the list of accepted author associations.

Detailed summary

  • Added github.event.pull_request.author_association == 'CONTRIBUTOR' to the conditions.
  • Retained github.event.pull_request.author_association == 'COLLABORATOR'.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 2, 2025

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 9c03b92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:58am

Copy link
Contributor

graphite-app bot commented Jan 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.19%. Comparing base (a9547c5) to head (9c03b92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5873   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files        1123     1123           
  Lines       59622    59622           
  Branches     5029     5029           
=======================================
  Hits        32906    32906           
  Misses      25996    25996           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a9547c5
packages 52.84% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 2.3 s (+3.18% 🔺) 3.2 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 5.9 s (-12.26% 🔽) 8.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 208 ms (-11.35% 🔽) 320 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 138 ms (+29.4% 🔺) 148 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 551 ms (-24.41% 🔽) 933 ms

@gregfromstl gregfromstl merged commit 128bb44 into main Jan 2, 2025
33 checks passed
@gregfromstl gregfromstl deleted the greg/tool-2896-ci-fix-auto-assign-job branch January 2, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant