Skip to content

return address type for contractoptions #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
16 changes: 8 additions & 8 deletions .changeset/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Changesets

Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works
with multi-package repos, or single-package repos to help you version and publish your code. You can
find the full documentation for it [in our repository](https://github.com/changesets/changesets)

We have a quick list of common questions to get you started engaging with this project in
[our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md)
# Changesets
Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works
with multi-package repos, or single-package repos to help you version and publish your code. You can
find the full documentation for it [in our repository](https://github.com/changesets/changesets)
We have a quick list of common questions to get you started engaging with this project in
[our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md)
42 changes: 21 additions & 21 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
{
"$schema": "https://unpkg.com/@changesets/config@2.1.1/schema.json",
"changelog": [
"@changesets/changelog-github",
{
"repo": "thirdweb-dev/js"
}
],
"commit": false,
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["playground-web", "thirdweb-dashboard", "wallet-ui", "portal"],
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"updateInternalDependents": "always",
"onlyUpdatePeerDependentsWhenOutOfRange": true
},
"snapshot": {
"prereleaseTemplate": "{tag}-{commit}-{datetime}"
}
}
{
"$schema": "https://unpkg.com/@changesets/config@2.1.1/schema.json",
"changelog": [
"@changesets/changelog-github",
{
"repo": "thirdweb-dev/js"
}
],
"commit": false,
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["playground-web", "thirdweb-dashboard", "wallet-ui", "portal"],
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"updateInternalDependents": "always",
"onlyUpdatePeerDependentsWhenOutOfRange": true
},
"snapshot": {
"prereleaseTemplate": "{tag}-{commit}-{datetime}"
}
}
10 changes: 5 additions & 5 deletions .changeset/cyan-shrimps-battle.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"thirdweb": patch
---

Update implementations
---
"thirdweb": patch
---
Update implementations
10 changes: 5 additions & 5 deletions .changeset/fair-planes-doubt.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"thirdweb": patch
---

SDK: Fix chain switching in smart account transactions
---
"thirdweb": patch
---
SDK: Fix chain switching in smart account transactions
38 changes: 19 additions & 19 deletions .changeset/metal-mails-ring.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
---
"thirdweb": patch
---

- Add onClose callback to Connect Details modal

```tsx
<ConnectButton
detailsModal={{
onClose: (screen: string) => {
// The last screen name that was being shown when user closed the modal
console.log({ screen });
}
}}
/>
```

- Small fix for ChainIcon: Always resolve IPFS URI

---
"thirdweb": patch
---
- Add onClose callback to Connect Details modal
```tsx
<ConnectButton
detailsModal={{
onClose: (screen: string) => {
// The last screen name that was being shown when user closed the modal
console.log({ screen });
}
}}
/>
```
- Small fix for ChainIcon: Always resolve IPFS URI
- Improve test coverage
14 changes: 7 additions & 7 deletions .env.example
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# rename this file to .env and fill in the values
# this is not required to build the packages but will significantly increase test performance

# used for unit tests that hit real IPFS gateway
# get a secret key from https://thirdweb.com/create-api-key
# Learn more about API keys. https://portal.thirdweb.com/account/api-keys
TW_SECRET_KEY=""
# rename this file to .env and fill in the values
# this is not required to build the packages but will significantly increase test performance
# used for unit tests that hit real IPFS gateway
# get a secret key from https://thirdweb.com/create-api-key
# Learn more about API keys. https://portal.thirdweb.com/account/api-keys
TW_SECRET_KEY=""
46 changes: 23 additions & 23 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
# Order is important; the last matching pattern takes the most precedence.

# default ownership group
@thirdweb-dev/developer-tools

# packages
packages/thirdweb/ @thirdweb-dev/core-platform @thirdweb-dev/developer-tools

## specific thirdweb pieces
packages/service-utils/ @thirdweb-dev/core-platform
packages/eslint-config-thirdweb/ @thirdweb-dev/core-platform @edwardysun
packages/tw-tsconfig/ @thirdweb-dev/core-platform @edwardysun

# apps
apps/ @thirdweb-dev/developer-tools @thirdweb-dev/core-platform @jakubkrehel

# .github folder + .changeset + turbo config is owned by jonas for now
scripts/ @jnsdls @joaquim-verges
.github/ @jnsdls @joaquim-verges
.changeset/config.json @jnsdls @joaquim-verges
turbo.json @jnsdls @joaquim-verges
.vscode/ @jnsdls @joaquim-verges

# Order is important; the last matching pattern takes the most precedence.
# default ownership group
@thirdweb-dev/developer-tools
# packages
packages/thirdweb/ @thirdweb-dev/core-platform @thirdweb-dev/developer-tools
## specific thirdweb pieces
packages/service-utils/ @thirdweb-dev/core-platform
packages/eslint-config-thirdweb/ @thirdweb-dev/core-platform @edwardysun
packages/tw-tsconfig/ @thirdweb-dev/core-platform @edwardysun
# apps
apps/ @thirdweb-dev/developer-tools @thirdweb-dev/core-platform @jakubkrehel
# .github folder + .changeset + turbo config is owned by jonas for now
scripts/ @jnsdls @joaquim-verges
.github/ @jnsdls @joaquim-verges
.changeset/config.json @jnsdls @joaquim-verges
turbo.json @jnsdls @joaquim-verges
.vscode/ @jnsdls @joaquim-verges
62 changes: 31 additions & 31 deletions .github/composite-actions/install/action.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
name: "Install"
description: "Sets up Node.js and runs install"

runs:
using: composite
steps:
# we use bun for some test suites
- name: Setup bun
uses: oven-sh/setup-bun@v1
with:
bun-version: 1.0.35
# pnpm for our dependencies
- uses: pnpm/action-setup@v3
with:
version: 9
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
check-latest: true
registry-url: "https://registry.npmjs.org"
cache: "pnpm"
- name: Install node-gyp globally
shell: bash
run: pnpm install -g node-gyp node-gyp-build

- name: Install dependencies
shell: bash
run: pnpm install
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: "1"
name: "Install"
description: "Sets up Node.js and runs install"
runs:
using: composite
steps:
# we use bun for some test suites
- name: Setup bun
uses: oven-sh/setup-bun@v1
with:
bun-version: 1.0.35
# pnpm for our dependencies
- uses: pnpm/action-setup@v3
with:
version: 9
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
check-latest: true
registry-url: "https://registry.npmjs.org"
cache: "pnpm"
- name: Install node-gyp globally
shell: bash
run: pnpm install -g node-gyp node-gyp-build
- name: Install dependencies
shell: bash
run: pnpm install
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: "1"
Loading
Loading