[SDK]: add backend wallets for in app wallet #5878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70b7b5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/wallets/in-app/core/authentication/backend.ts
Outdated
Show resolved
Hide resolved
ElasticBottle
changed the title
size-limit report 📦
|
gregfromstl
reviewed
Jan 3, 2025
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Jan 7, 2025
--- title: "[SDK] Feature: add backend wallets for in app wallet" --- https://linear.app/thirdweb/issue/TOOL-2884/backend-server-wallets ## Notes for the reviewer This also fixes the cache mechanics for thirdweb clients to include a partial string of the secret key. Was running into an issue where the client was originall instantiated without the secret key and even when a new client with secret key was passed in, we keep falling back to the cached client without secret key ## How to test Add a button on playground with a client that has secret key and create a new backend wallet. <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces support for backend wallet authentication in the `thirdweb` library, allowing applications to connect to wallet accounts programmatically without managing private keys. ### Detailed summary - Added `backend` strategy for wallet authentication. - Updated `authenticate` functions to include backend authentication examples. - Introduced `backendAuthenticate` function for server-side authentication. - Modified `InAppWebConnector` and `InAppNativeConnector` to handle backend authentication. - Enhanced type definitions to include `backend` strategy. - Added tests for `backendAuthenticate` and its integration in connectors. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
winston/tool-2884-backend-server-wallets
branch
from
70694d1 to
a21ff2c
Compare
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
--- title: "[SDK] Feature: add backend wallets for in app wallet" --- https://linear.app/thirdweb/issue/TOOL-2884/backend-server-wallets ## Notes for the reviewer This also fixes the cache mechanics for thirdweb clients to include a partial string of the secret key. Was running into an issue where the client was originall instantiated without the secret key and even when a new client with secret key was passed in, we keep falling back to the cached client without secret key ## How to test Add a button on playground with a client that has secret key and create a new backend wallet. <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces support for backend wallets in the `thirdweb` library, allowing applications to authenticate users with a backend strategy, enhancing security by managing wallet access without exposing private keys. ### Detailed summary - Added `backend` strategy for wallet authentication. - Updated `authenticate` function to support `backend` strategy. - Introduced `backendAuthenticate` function for backend authentication. - Updated `InAppWebConnector` and `InAppNativeConnector` to handle `backend` strategy. - Modified type definitions to include `backend` strategy. - Added tests for `backendAuthenticate` and its integration in connectors. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
winston/tool-2884-backend-server-wallets
branch
from
14d4cb6 to
70b7b5c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: "[SDK] Feature: add backend wallets for in app wallet"
https://linear.app/thirdweb/issue/TOOL-2884/backend-server-wallets
Notes for the reviewer
This also fixes the cache mechanics for thirdweb clients to include a partial string of the secret key. Was running into an issue where the client was originall instantiated without the secret key and even when a new client with secret key was passed in, we keep falling back to the cached client without secret key
How to test
Add a button on playground with a client that has secret key and create a new backend wallet.
PR-Codex overview
This PR introduces support for backend wallet authentication in the
thirdweblibrary, allowing applications to authenticate users via a backend account without managing private keys.Detailed summary
backendstrategy for wallet authentication.authenticatefunction to support backend authentication.InAppWebConnectorandInAppNativeConnectorto handle backend authentication.backendAuthenticatefunction for server-side authentication.backendAuthenticateand related functionality.