-
Notifications
You must be signed in to change notification settings - Fork 542
[TOOL-2917]: fix useReadContract type hinting #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
df05843
to
5970df9
Compare
5970df9
to
d333099
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5888 +/- ##
==========================================
+ Coverage 55.19% 55.29% +0.10%
==========================================
Files 1123 1123
Lines 59622 59646 +24
Branches 5029 5044 +15
==========================================
+ Hits 32906 32980 +74
+ Misses 25996 25945 -51
- Partials 720 721 +1
*This pull request uses carry forward flags. Click here to find out more.
|
d333099
to
0523a12
Compare
0523a12
to
6ca7886
Compare
Notes for the reviewer
PR-Codex overview
This PR focuses on enhancing the
useReadContract
hook by introducing new type definitions and improving type safety for contract interactions in thethirdweb
package.Detailed summary
Extension
type intypes.ts
for transaction options.AbiOfLength
andAsyncGetAbiFunctionFromContract
types incontract/types.ts
.PickedOnceQueryOptions
andWithPickedOnceQueryOptions
inhooks/types.ts
.useReadContract
to utilize new types for better type safety.useReadContract
.