-
Notifications
You must be signed in to change notification settings - Fork 544
[TOOL-3038] Replace h-screen with h-dvh - fix iOS safari height issues #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-3038] Replace h-screen with h-dvh - fix iOS safari height issues #5932
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5932 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 1141 1141
Lines 60903 60903
Branches 5128 5128
=======================================
Hits 33396 33396
Misses 26781 26781
Partials 726 726
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
4247c49
to
3cb1ab9
Compare
|
PR-Codex overview
This PR focuses on updating the minimum height CSS class from
min-h-screen
tomin-h-dvh
across various components in the application, enhancing the layout's responsiveness and ensuring it adapts better to dynamic viewport heights.Detailed summary
min-h-screen
withmin-h-dvh
in multiple components:layout.tsx
inteam/[team_slug]
,account
,drops/[slug]
, andnebula-app/(app)
ChatPageLayout.tsx
,page.tsx
, andStepsCard.stories.tsx
TeamHeaderLoggedOut.stories.tsx
,AccountHeaderUI.stories.tsx
, and others