Skip to content

[TOOL-3038] Replace h-screen with h-dvh - fix iOS safari height issues #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jan 12, 2025

PR-Codex overview

This PR focuses on updating the minimum height CSS class from min-h-screen to min-h-dvh across various components in the application, enhancing the layout's responsiveness and ensuring it adapts better to dynamic viewport heights.

Detailed summary

  • Replaced min-h-screen with min-h-dvh in multiple components:
    • layout.tsx in team/[team_slug], account, drops/[slug], and nebula-app/(app)
    • ChatPageLayout.tsx, page.tsx, and StepsCard.stories.tsx
    • Various story files like TeamHeaderLoggedOut.stories.tsx, AccountHeaderUI.stories.tsx, and others
  • Ensured consistent styling and improved responsiveness across the application.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 12, 2025

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 7:21pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 7:21pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 12, 2025 7:21pm
wallet-ui ⬜️ Skipped (Inspect) Jan 12, 2025 7:21pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 12, 2025 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 12, 2025 14:32 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. labels Jan 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review January 12, 2025 14:32
@MananTank MananTank requested review from a team as code owners January 12, 2025 14:32
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (5c55473) to head (3cb1ab9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5932   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60903    60903           
  Branches     5128     5128           
=======================================
  Hits        33396    33396           
  Misses      26781    26781           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5c55473
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 2.8 s (-27.06% 🔽) 3.8 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 6 s (-10.07% 🔽) 8.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 389 ms (+22.32% 🔺) 500 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 79 ms (-56.87% 🔽) 89 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 1.2 s (+73.68% 🔺) 1.6 s

@MananTank MananTank marked this pull request as draft January 12, 2025 14:44
@MananTank MananTank marked this pull request as ready for review January 12, 2025 14:44
Copy link
Contributor

graphite-app bot commented Jan 12, 2025

Merge activity

@MananTank MananTank force-pushed the 01-12-_tool-3038_replace_h-screen_with_h-dvh_-_fix_ios_safari_height_issues branch from 4247c49 to 3cb1ab9 Compare January 12, 2025 19:18
Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: 3cb1ab9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 12, 2025 19:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 12, 2025 19:18 Inactive
@graphite-app graphite-app bot merged commit 3cb1ab9 into main Jan 12, 2025
31 checks passed
@graphite-app graphite-app bot deleted the 01-12-_tool-3038_replace_h-screen_with_h-dvh_-_fix_ios_safari_height_issues branch January 12, 2025 19:21
@vercel vercel bot temporarily deployed to Production – wallet-ui January 12, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 12, 2025 19:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants