Skip to content

[TOOL-3047] Dashboard: Fix TransactionButton opening "No funds" Modal when quickly clicking it after switching chain #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jan 13, 2025

PR-Codex overview

This PR focuses on renaming and refactoring variables related to chain ID handling in the TransactionButton and MismatchButton components to improve clarity and consistency.

Detailed summary

  • Renamed desiredChainId to txChainId in multiple components.
  • Updated function useNetworkMismatchAdapter to useIsNetworkMismatch.
  • Adjusted logic in MismatchButton for balance checks using txChainId.
  • Modified MismatchNotice to use txChainId.
  • Enhanced user prompts for transaction approval messages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 13, 2025

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 13, 2025 17:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 13, 2025 17:27 Inactive
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:37pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 13, 2025 11:37pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 13, 2025 11:37pm
wallet-ui ⬜️ Skipped (Inspect) Jan 13, 2025 11:37pm

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 0682f26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 13, 2025 17:27 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 13, 2025
@MananTank MananTank marked this pull request as ready for review January 13, 2025 17:28
@MananTank MananTank requested review from a team as code owners January 13, 2025 17:28
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [TOOL-3047] Dashboard: Fix TransactionButton opening Not enough funds Modal when quickly clicking it after switching chain [TOOL-3047] Dashboard: Fix TransactionButton opening "Not enough funds" Modal when quickly clicking it after switching chain Jan 13, 2025
@MananTank MananTank changed the title [TOOL-3047] Dashboard: Fix TransactionButton opening "Not enough funds" Modal when quickly clicking it after switching chain [TOOL-3047] Dashboard: Fix TransactionButton opening "No funds" Modal when quickly clicking it after switching chain Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.85%. Comparing base (0e2b3df) to head (0682f26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5941   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files        1142     1142           
  Lines       60928    60928           
  Branches     5140     5140           
=======================================
  Hits        33424    33424           
  Misses      26777    26777           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0e2b3df
packages 52.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 2.8 s (+26.11% 🔺) 3.7 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 6 s (+15.76% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 349 ms (-43.02% 🔽) 461 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 201 ms (+30.38% 🔺) 211 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 898 ms (+29.56% 🔺) 1.3 s

Copy link
Contributor

graphite-app bot commented Jan 13, 2025

Merge activity

… when quickly clicking it after switching chain (#5941)
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 13, 2025 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 13, 2025 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 13, 2025 23:28 Inactive
@graphite-app graphite-app bot merged commit 0682f26 into main Jan 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3047 branch January 14, 2025 00:23
@vercel vercel bot temporarily deployed to Production – docs-v2 January 14, 2025 00:23 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 14, 2025 00:23 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 14, 2025 00:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants