-
Notifications
You must be signed in to change notification settings - Fork 544
[TOOL-3047] Dashboard: Fix TransactionButton opening "No funds" Modal when quickly clicking it after switching chain #5941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5941 +/- ##
=======================================
Coverage 54.85% 54.85%
=======================================
Files 1142 1142
Lines 60928 60928
Branches 5140 5140
=======================================
Hits 33424 33424
Misses 26777 26777
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
… when quickly clicking it after switching chain (#5941)
PR-Codex overview
This PR focuses on renaming and refactoring variables related to chain ID handling in the
TransactionButton
andMismatchButton
components to improve clarity and consistency.Detailed summary
desiredChainId
totxChainId
in multiple components.useNetworkMismatchAdapter
touseIsNetworkMismatch
.MismatchButton
for balance checks usingtxChainId
.MismatchNotice
to usetxChainId
.