-
Notifications
You must be signed in to change notification settings - Fork 543
[SDK] Feat: Add engineAccount() for backend transaction handling #5947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Feat: Add engineAccount() for backend transaction handling #5947
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d256799 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
throw new Error("Transaction timed out after 5 minutes"); | ||
}, | ||
signMessage: async ({ message }) => { | ||
let engineMesasage: string | Hex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable engineMesasage
contains a typo and should be renamed to engineMessage
for correct spelling.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5947 +/- ##
==========================================
- Coverage 54.96% 54.89% -0.07%
==========================================
Files 1145 1146 +1
Lines 60996 61108 +112
Branches 5156 5154 -2
==========================================
+ Hits 33528 33548 +20
- Misses 26740 26832 +92
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more.
|
82d6b2f
to
7566e51
Compare
7566e51
to
f38bcb4
Compare
f38bcb4
to
97e1236
Compare
97e1236
to
eb96d45
Compare
eb96d45
to
d256799
Compare
Fixes: TOOL-3057
Notes for the reviewer
Requires new env variables for testing, see
.env.example
How to test
Add env variables, run
engine-account.test.ts
PR-Codex overview
This PR introduces the
engineAccount()
function for backend usage, allowing the creation of accounts that can send transactions through an engine instance. It enhances the SDK with options for signing messages, sending transactions, and managing accounts effectively.Detailed summary
EngineAccountOptions
andengineAccount
from../../wallets/engine/index.js
..env.example
to includeENGINE_URL
,ENGINE_AUTH_TOKEN
, andENGINE_WALLET_ADDRESS
.engineAccount
inengine-account.test.ts
, covering message signing and transaction sending.engineAccount
function to handle signing messages, typed data, and sending transactions with error handling.