Skip to content

track ratelimit only on creation #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2025
Merged

track ratelimit only on creation #5950

merged 7 commits into from
Jan 15, 2025

Conversation

nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Jan 14, 2025

PR-Codex overview

This PR focuses on improving the rate limiting functionality in the service-utils package. It modifies how rate limit hits are reported and updates tests to reflect changes in behavior.

Detailed summary

  • Updated the logic in updateRateLimitedAt to only track rate limit hits on the first occurrence.
  • Changed the return structure for rate limit exceeded responses.
  • Modified tests to reflect the new behavior of rate limiting and updated mock implementations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra requested a review from arcoraven January 14, 2025 16:02
@nischitpra nischitpra requested a review from a team as a code owner January 14, 2025 16:02
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 45c046f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 7:19am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 7:19am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 7:19am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 7:19am

Copy link
Contributor

github-actions bot commented Jan 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 692 ms (+18.62% 🔺) 1.7 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 1.5 s (+16.61% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 182 ms (+315.57% 🔺) 294 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (+33.23% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 203 ms (+57.97% 🔺) 588 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 16:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants