Skip to content

[Portal] Fix: Updating AA supported chains #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

Joe-Thirdweb
Copy link
Contributor

@Joe-Thirdweb Joe-Thirdweb commented Mar 10, 2025

Removing the table of chains and replacing with a link to the chainlist page.

SOL2-25

How to test

Visit portal.thirdweb.com

  1. Click on connect
  2. Click on account abstraction
  3. Click on Bundler & Paymaster
  4. See the previous table of chains has been replaced with a link to the chainlist.
  5. See the attached doc image.

PR-Codex overview

This PR enhances the page.mdx file by adding a link for users to view all supported chains with Account Abstraction and includes an image of the supported chains.

Detailed summary

  • Added a link: [View all supported chains with Account Abstraction](https://thirdweb.com/chainlist?service=account-abstraction)
  • Included an image component: <DocImage src={SupportedChains} /> displaying supported chains.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Replacing table with link to chainlist page. 
Adding image.

Signed-off-by: Joe-Thirdweb <160192317+Joe-Thirdweb@users.noreply.github.com>
Replacing AAchainlist import with DocImage

Signed-off-by: Joe-Thirdweb <160192317+Joe-Thirdweb@users.noreply.github.com>
@Joe-Thirdweb Joe-Thirdweb requested review from a team as code owners March 10, 2025 20:20
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 9e586e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 2:37am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 12, 2025 2:37am
login ⬜️ Skipped (Inspect) Mar 12, 2025 2:37am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 12, 2025 2:37am
wallet-ui ⬜️ Skipped (Inspect) Mar 12, 2025 2:37am

Copy link
Contributor

graphite-app bot commented Mar 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (d8865b7) to head (9e586e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6459   +/-   ##
=======================================
  Coverage   54.81%   54.81%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3735     3735           
=======================================
  Hits        30066    30066           
  Misses      24690    24690           
  Partials       95       95           
Flag Coverage Δ
packages 54.81% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 157 ms (-9.39% 🔽) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 415 ms (+8.37% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 53 ms (+354.34% 🔺) 165 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+511.67% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 42 ms (+38.87% 🔺) 428 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 12, 2025 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 12, 2025 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 12, 2025 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 12, 2025 02:31 Inactive
@joaquim-verges joaquim-verges merged commit 58cd794 into main Mar 12, 2025
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the Joe---AA-Supported-Chains branch March 12, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants