Skip to content

[TOOL-3683] Dashboard: enforce project creation teams with no projects #6462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 11, 2025

PR-Codex overview

This PR focuses on enhancing the project creation and onboarding experience in the dashboard application. It introduces new components and modifies existing ones to streamline project management and improve user navigation.

Detailed summary

  • Updated onCreateAndComplete to onCreate in AccountHeader.tsx and TeamHeader.tsx.
  • Changed redirect path in team-onboarding.tsx to /get-started/team/${props.team.slug}/create-project.
  • Added CreateProjectPage to handle project creation in create-project/page.tsx.
  • Introduced CreateProjectPageUI for the project creation form in create-project-page.tsx.
  • Added onboarding steps in onboarding-layout.tsx for project configuration and key storage.
  • Enhanced RootTeamLayout to handle project loading and redirection based on project existence.
  • Integrated TeamProjectsTable in TeamProjectsPage.tsx for displaying projects.
  • Removed unused components and simplified logic in TeamProjectsPage.tsx.
  • Updated CreateProjectDialog to use onCreate callback for refreshing after project creation.
  • Refactored CreatedProjectDetails and CreateProjectForm for better UI and usability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 11, 2025

Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: 7c0acce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:50pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:50pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:50pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:50pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:50pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 11, 2025 14:09 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 11, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 11, 2025 14:10
@MananTank MananTank requested review from a team as code owners March 11, 2025 14:10
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (a1141f3) to head (7c0acce).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6462   +/-   ##
=======================================
  Coverage   54.81%   54.81%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3736     3735    -1     
=======================================
  Hits        30066    30066           
  Misses      24690    24690           
  Partials       95       95           
Flag Coverage Δ
packages ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 180 ms (+112.9% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 332 ms (+34.34% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 89 ms (+752.6% 🔺) 201 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 38 ms (+896.55% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 85 ms (+356.47% 🔺) 472 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 14:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 11, 2025 14:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 14:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 14:31 Inactive
@MananTank MananTank marked this pull request as draft March 11, 2025 17:26
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 11, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 11, 2025 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 20:18 Inactive
@MananTank MananTank changed the title [TOOL-3683] Dashboard: show FTUX in team overview page when no projects are created [TOOL-3683] Dashboard: Add project onboarding flow Mar 11, 2025
@MananTank MananTank changed the title [TOOL-3683] Dashboard: Add project onboarding flow [TOOL-3683] Dashboard: enforce project creation for a team Mar 11, 2025
@MananTank MananTank changed the title [TOOL-3683] Dashboard: enforce project creation for a team [TOOL-3683] Dashboard: enforce project creation teams with no projects Mar 11, 2025
@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 11, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 20:38 Inactive
@MananTank MananTank marked this pull request as ready for review March 11, 2025 20:38
Copy link
Contributor

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added Stale and removed Stale labels Mar 19, 2025
@MananTank MananTank closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants