Skip to content

[TOOL-3691] Dashbaord: Keep project settings submit button always enabled #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

[TOOL-3691] Dashbaord: Keep project settings submit button always enabled #6467

merged 1 commit into from
Mar 13, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 12, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the handling of form state in the ProjectGeneralSettingsPage.tsx file by removing unnecessary checks for whether the form fields are dirty, simplifying the save button logic.

Detailed summary

  • Removed isDirty checks for name, domains, and bundleIds fields.
  • Set disabled property of save buttons to false for all settings.
  • Adjusted isPending property to only depend on props.isUpdatingProject.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear Linear
Copy link

linear bot commented Mar 12, 2025

TOOL-3691 Refresh needed to save after deleting domains in projects

@vercel Vercel
Copy link

vercel bot commented Mar 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 10:55pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 13, 2025 10:55pm
login ⬜️ Skipped (Inspect) Mar 13, 2025 10:55pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 13, 2025 10:55pm
wallet-ui ⬜️ Skipped (Inspect) Mar 13, 2025 10:55pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 12, 2025 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 12, 2025 17:52 Inactive
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 269fbe5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 12, 2025 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 12, 2025 17:52 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 12, 2025
@MananTank MananTank marked this pull request as ready for review March 12, 2025 17:52
@MananTank MananTank requested review from a team as code owners March 12, 2025 17:52
@MananTank Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (7ed8fc2) to head (269fbe5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6467   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3738     3738           
=======================================
  Hits        30062    30062           
  Misses      24695    24695           
  Partials       94       94
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 133 ms (+149.87% 🔺) 1.1 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 218 ms (+27.35% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 80 ms (+1102.94% 🔺) 192 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (+984.07% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 80 ms (+687.31% 🔺) 467 ms

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 13, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3691] Dashbaord: Keep project settings submit button always ena…
269fbe5 
…bled (#6467)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on simplifying the logic for determining if form fields are "dirty" before enabling the save button in the `ProjectGeneralSettingsPage`. It removes checks for dirty states, allowing the save button to be enabled regardless of whether the fields have been modified.

### Detailed summary
- Removed `isNameDirty` check for the `name` field in `ProjectNameSetting`.
- Removed `isDomainsDirty` check for the `domains` field in `AllowedDomainsSetting`.
- Removed `isBundleIdsDirty` check for the `bundleIds` field in `AllowedBundleIDsSetting`.
- Updated save button to always have `disabled: false` for all settings.
- Kept `isPending` functionality unchanged based on `props.isUpdatingProject`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 13, 2025 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 13, 2025 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 13, 2025 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 13, 2025 22:48 Inactive
@graphite-app graphite-app bot merged commit 269fbe5 into main Mar 13, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3691 branch March 13, 2025 22:56
@vercel vercel bot temporarily deployed to Production – wallet-ui March 13, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 13, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 13, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Production – login March 13, 2025 22:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@jnsdls jnsdls jnsdls approved these changes

@0xFirekeeper 0xFirekeeper 0xFirekeeper approved these changes

Assignees

@MananTank MananTank

Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MananTank @jnsdls @0xFirekeeper