.NET Docs - Synchronous EngineWallet.Create #6469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
0xFirekeeper
added
the
merge-queue
github-actions
bot
added
the
Portal
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6469 +/- ##
=======================================
Coverage 54.82% 54.82%
=======================================
Files 875 875
Lines 54851 54851
Branches 3740 3740
=======================================
Hits 30071 30071
Misses 24685 24685
Partials 95 95
🚀 New features to boost your workflow:
|
size-limit report 📦
|
0xFirekeeper
added
merge-queue
jnsdls
approved these changes
Mar 13, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on modifying the instantiation of the `engineWallet` variable by removing the `await` keyword, indicating a change in how the `EngineWallet.Create` method is called.
### Detailed summary
- Changed `var engineWallet = await EngineWallet.Create(` to `var engineWallet = EngineWallet.Create(`.
- This change suggests that `EngineWallet.Create` no longer returns a promise or that the method is being called synchronously.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
firekeeper/sync-enginewallet
branch
from
76e8057 to
b10793e
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
<!-- start pr-codex -->
## PR-Codex overview
This PR updates the instantiation of the `EngineWallet` object by removing the `await` keyword. This change suggests that the `Create` method is no longer asynchronous or has been refactored to not require awaiting.
### Detailed summary
- Changed the instantiation of `engineWallet` from an asynchronous call using `await` to a synchronous call.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
firekeeper/sync-enginewallet
branch
from
b10793e to
0d416d6
Compare
graphite-app
bot
removed
the
merge-queue
joaquim-verges
approved these changes
Mar 13, 2025
0xFirekeeper
added
the
merge-queue
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on modifying the instantiation of the `engineWallet` variable by removing the `await` keyword from the `EngineWallet.Create` method call, indicating a change in how the method is executed.
### Detailed summary
- Removed `await` from the `EngineWallet.Create` method call for `engineWallet`.
- The method now executes synchronously instead of asynchronously.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
firekeeper/sync-enginewallet
branch
from
7af5a0f to
71f83a8
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on modifying the instantiation of the
engineWalletvariable by removing theawaitkeyword, indicating a change in how theEngineWallet.Createmethod is called.Detailed summary
awaitfrom the instantiation ofengineWallet.