Skip to content

[Dashboard] feat: Add access control and server verifier to partner configuration #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 14, 2025


PR-Codex overview

This PR introduces an accessControl feature, enhancing partner management by adding server verification capabilities. It updates the form handling for adding and updating partners to include access control options and validation.

Detailed summary

  • Added accessControl property with serverVerifier to partner types.
  • Updated use-partners hook to sort partners by createdAt.
  • Enhanced useUpdatePartner and useAddPartner hooks to handle accessControl.
  • Introduced a new PartnerForm component for form handling.
  • Added validation for server verifier URL and headers in the form schema.
  • Refactored forms to use PartnerForm for adding and updating partners.
  • Implemented UI controls for toggling access control and server verifier settings.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – login March 14, 2025 04:25 Inactive
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:14am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 14, 2025 6:14am
login ⬜️ Skipped (Inspect) Mar 14, 2025 6:14am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 14, 2025 6:14am
wallet-ui ⬜️ Skipped (Inspect) Mar 14, 2025 6:14am

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 14, 2025 04:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 14, 2025 04:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 14, 2025 04:25 Inactive
Copy link

changeset-bot bot commented Mar 14, 2025

⚠️ No Changeset found

Latest commit: 1849fcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 14, 2025 04:29
@joaquim-verges joaquim-verges requested review from a team as code owners March 14, 2025 04:29
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (269fbe5) to head (1849fcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6473   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3738     3738           
=======================================
  Hits        30062    30062           
  Misses      24695    24695           
  Partials       94       94           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 128 ms (+125.03% 🔺) 1.1 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 212 ms (+29.96% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 75 ms (+1383.49% 🔺) 187 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+1357.34% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 85 ms (+481.59% 🔺) 472 ms

@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_access_control_and_server_verifier_to_partner_configuration branch from e60b88b to 131f1a9 Compare March 14, 2025 05:55
@vercel vercel bot temporarily deployed to Preview – login March 14, 2025 05:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 14, 2025 05:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 14, 2025 05:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 14, 2025 05:55 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_access_control_and_server_verifier_to_partner_configuration branch from 131f1a9 to 04521b9 Compare March 14, 2025 05:59
@vercel vercel bot temporarily deployed to Preview – login March 14, 2025 05:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 14, 2025 05:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 14, 2025 05:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 14, 2025 05:59 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_feat_Add_access_control_and_server_verifier_to_partner_configuration branch from 04521b9 to 1849fcc Compare March 14, 2025 06:02
@vercel vercel bot temporarily deployed to Preview – login March 14, 2025 06:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 14, 2025 06:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 14, 2025 06:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 14, 2025 06:02 Inactive
@joaquim-verges joaquim-verges merged commit 90010ee into main Mar 14, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_feat_Add_access_control_and_server_verifier_to_partner_configuration branch March 14, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant