Skip to content

updated description of using session keys with Engine #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2025

Conversation

eabdelmoneim
Copy link
Contributor

@eabdelmoneim eabdelmoneim commented Mar 14, 2025


PR-Codex overview

This PR updates the documentation for account transactions, emphasizing the use of session keys for interacting with smart accounts. It clarifies the roles of the x-backend-wallet-address and x-account-address headers.

Detailed summary

  • Updated section title to Transact with an account using session keys.
  • Clarified that the x-backend-wallet-address must be from a wallet granted signing permission via a session key.
  • Specified that the x-account-address refers to the deployed smart account address.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Eiman <eabdelmoneim@gmail.com>
@eabdelmoneim eabdelmoneim requested review from a team as code owners March 14, 2025 14:58
Copy link

changeset-bot bot commented Mar 14, 2025

⚠️ No Changeset found

Latest commit: b8e8462

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2025 3:47am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 15, 2025 3:47am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 15, 2025 3:47am
thirdweb-www ⬜️ Skipped (Inspect) Mar 15, 2025 3:47am
wallet-ui ⬜️ Skipped (Inspect) Mar 15, 2025 3:47am

Copy link
Contributor

graphite-app bot commented Mar 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (90010ee) to head (b8e8462).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6474   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3738     3738           
=======================================
  Hits        30062    30062           
  Misses      24695    24695           
  Partials       94       94           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 130 ms (+267.97% 🔺) 1.1 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 170 ms (+130.11% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 101 ms (+3506.45% 🔺) 213 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 62 ms (+7527.39% 🔺) 72 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 83 ms (+1340.55% 🔺) 470 ms

Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
Signed-off-by: Joaquim Verges <joaquim.verges@gmail.com>
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 15, 2025 03:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 15, 2025 03:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 15, 2025 03:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 15, 2025 03:33 Inactive
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: Joaquim Verges <joaquim.verges@gmail.com>
@vercel vercel bot temporarily deployed to Preview – login March 15, 2025 03:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 15, 2025 03:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 15, 2025 03:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 15, 2025 03:34 Inactive
@jnsdls jnsdls merged commit 5371820 into main Mar 15, 2025
32 checks passed
@jnsdls jnsdls deleted the eabdelmoneim-patch-1 branch March 15, 2025 22:25
Dargon789 referenced this pull request in Dargon789/js Mar 16, 2025
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants