Skip to content

Revert "[Service-Utils] feat: Add engine-cloud service definition #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 24, 2025

This reverts commit 21389bb.


PR-Codex overview

This PR focuses on removing the engineCloud service definition from the api.ts and services.ts files, streamlining the service structure.

Detailed summary

  • Removed the engineCloud service definition in api.ts.
  • Deleted the entire engineCloud object in services.ts, including its properties: name, title, description, and actions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges requested a review from a team as a code owner March 24, 2025 09:23
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: d24ff14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 9:29am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 24, 2025 9:29am
login ⬜️ Skipped (Inspect) Mar 24, 2025 9:29am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 24, 2025 9:29am
wallet-ui ⬜️ Skipped (Inspect) Mar 24, 2025 9:29am

Copy link
Contributor

graphite-app bot commented Mar 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 167 ms (+147.78% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 228 ms (+37.38% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 97 ms (+1639.65% 🔺) 209 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 46 ms (+2057.24% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 89 ms (+709.52% 🔺) 476 ms

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.92%. Comparing base (ab7bf1a) to head (d24ff14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6529   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         881      881           
  Lines       55179    55179           
  Branches     3768     3768           
=======================================
  Hits        30309    30309           
  Misses      24775    24775           
  Partials       95       95           
Flag Coverage Δ
packages 54.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant