Skip to content

[Dashboard] Disable engineCloud service by default #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 24, 2025


PR-Codex overview

This PR focuses on updating the handling of hidden services in the ApiKeys component and modifying the service filtering logic in the Create component to include an additional service.

Detailed summary

  • In validations.ts, HIDDEN_SERVICES is updated to include "engineCloud".
  • In index.tsx, the filtering logic for ALL_PROJECT_SERVICES is modified to exclude "engineCloud" as well, with a comment indicating it will be enabled once the API server is ready.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 9:42am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 24, 2025 9:42am
login ⬜️ Skipped (Inspect) Mar 24, 2025 9:42am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 24, 2025 9:42am
wallet-ui ⬜️ Skipped (Inspect) Mar 24, 2025 9:42am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 09:25 Inactive
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 9a538a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Mar 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Disable_engineCloud_service_by_default branch from 7fcb0ed to 043d23c Compare March 24, 2025 09:26
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 09:26 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review March 24, 2025 09:26
@joaquim-verges joaquim-verges requested review from a team as code owners March 24, 2025 09:26
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 09:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 09:28 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 09:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 09:28 Inactive
@joaquim-verges joaquim-verges force-pushed the _Dashboard_Disable_engineCloud_service_by_default branch from f3b889f to 9a538a3 Compare March 24, 2025 09:30
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 09:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 09:30 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 09:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 09:30 Inactive
@joaquim-verges joaquim-verges merged commit d9091bd into main Mar 24, 2025
28 of 29 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Disable_engineCloud_service_by_default branch March 24, 2025 09:31
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 182 ms (+224.02% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 254 ms (+54.2% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 90 ms (+1302.92% 🔺) 202 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+2998.45% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 125 ms (+835.14% 🔺) 512 ms

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.92%. Comparing base (ab7bf1a) to head (9a538a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6530   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         881      881           
  Lines       55179    55179           
  Branches     3768     3768           
=======================================
  Hits        30309    30309           
  Misses      24775    24775           
  Partials       95       95           
Flag Coverage Δ
packages 54.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants