[TOOL-3689] Dashboard: Keep switch in disabled state if field value is empty in Sponsorship rules form #6535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6535 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 881 881
Lines 55304 55304
Branches 3787 3787
=======================================
Hits 30429 30429
Misses 24780 24780
Partials 95 95
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
approved these changes
Mar 25, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
…s empty in Sponsorship rules form (#6535) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the handling of various policy attributes in the `transformedQueryData` object within the `AccountAbstractionSettingsPage` component. The changes ensure that only non-empty values are included, addressing potential issues with null or empty arrays. ### Detailed summary - Refactored `transformedQueryData` to filter out empty values from `allowedContractAddresses`, `allowedWallets`, `blockedWallets`, and `allowedChainIds`. - Simplified conditionals for returning values by directly using filtered results. - Updated the handling of `allowedChainIds` to default to an empty array instead of null. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
tool-3689
branch
from
958e8a1 to
69927c9
Compare
MananTank
added a commit
that referenced
this pull request
Mar 25, 2025
…s empty in Sponsorship rules form (#6535) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the handling of various policy attributes in the `transformedQueryData` object within the `AccountAbstractionSettingsPage` component. The changes ensure that only non-empty values are included, addressing potential issues with null or empty arrays. ### Detailed summary - Refactored `transformedQueryData` to filter out empty values from `allowedContractAddresses`, `allowedWallets`, `blockedWallets`, and `allowedChainIds`. - Simplified conditionals for returning values by directly using filtered results. - Updated the handling of `allowedChainIds` to default to an empty array instead of null. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
…s empty in Sponsorship rules form (#6535) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the `transformedQueryData` computation by filtering out empty values from the `policy` properties. It enhances data handling for `allowedContractAddresses`, `allowedWallets`, `blockedWallets`, and `allowedChainIds`, ensuring cleaner and more accurate data is returned. ### Detailed summary - Refactored `transformedQueryData` to filter out empty values from `allowedContractAddresses`, `allowedWallets`, `blockedWallets`, and `allowedChainIds`. - Simplified return conditions for these properties. - Changed handling of `allowedChainIds` to return an empty array instead of null to prevent API issues. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
tool-3689
branch
from
751044a to
f1df19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring the data transformation logic in the
transformedQueryDataobject to improve the handling ofallowedContractAddresses,allowedWallets,blockedWallets, andallowedChainIds, ensuring that empty values are filtered out properly.Detailed summary
transformedQueryDatato filter out empty strings and zeros fromallowedContractAddresses,allowedWallets,blockedWallets, andallowedChainIds.allowedChainIdsdefaults to an empty array instead of null in the parsed values.