Skip to content

[Playground] Rename "Fund Wallet" to "Buy Crypto" across pay components #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 26, 2025


PR-Codex overview

This PR focuses on renaming instances of "Fund Wallet" to "Buy Crypto" across various files to reflect a change in terminology for a payment option.

Detailed summary

  • Updated name from "Fund Wallet" to "Buy Crypto" in navLinks.ts.
  • Changed the displayed text from "Fund Wallet" to "Buy Crypto" in RightSection.tsx.
  • Altered the label for fund_wallet from "Fund Wallet" to "Buy Crypto" in LeftSection.tsx.
  • Updated the page title from "Fund wallets | thirdweb Universal Bridge" to "Buy Crypto | thirdweb Universal Bridge" in page.tsx.
  • Changed the heading from "Fund Wallet" to "Buy Crypto" in the StyledPayEmbed function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 0:43am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 26, 2025 0:43am
login ⬜️ Skipped (Inspect) Mar 26, 2025 0:43am
thirdweb-www ⬜️ Skipped (Inspect) Mar 26, 2025 0:43am
wallet-ui ⬜️ Skipped (Inspect) Mar 26, 2025 0:43am

@vercel vercel bot temporarily deployed to Preview – login March 26, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 26, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 26, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 26, 2025 00:40 Inactive
Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: be10158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review March 26, 2025 00:40
@joaquim-verges joaquim-verges requested review from a team as code owners March 26, 2025 00:40
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Mar 26, 2025
Copy link
Member Author

joaquim-verges commented Mar 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.07%. Comparing base (3c120a7) to head (be10158).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6555   +/-   ##
=======================================
  Coverage   55.07%   55.07%           
=======================================
  Files         883      883           
  Lines       55362    55362           
  Branches     3789     3789           
=======================================
  Hits        30491    30491           
  Misses      24776    24776           
  Partials       95       95           
Flag Coverage Δ
packages 55.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 182 ms (+113.77% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 278 ms (+4.03% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 82 ms (+1171.32% 🔺) 195 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+1168.88% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 91 ms (+325.67% 🔺) 478 ms

@joaquim-verges joaquim-verges merged commit fe8b3ce into main Mar 26, 2025
35 checks passed
@joaquim-verges joaquim-verges deleted the _Playground_Rename_Fund_Wallet_to_Buy_Crypto_across_pay_components branch March 26, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant