Skip to content

fix: reduce cost of playground commerce example #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 29, 2025


PR-Codex overview

This PR focuses on updating the amount in the paymentInfo object within the direct-payment.tsx file to reflect a new payment value.

Detailed summary

  • Changed amount from "2" to "0.25" in the paymentInfo object.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners March 29, 2025 02:18
Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: 2dae647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 2:18am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 29, 2025 2:18am
login ⬜️ Skipped (Inspect) Mar 29, 2025 2:18am
thirdweb-www ⬜️ Skipped (Inspect) Mar 29, 2025 2:18am
wallet-ui ⬜️ Skipped (Inspect) Mar 29, 2025 2:18am

Copy link
Contributor

graphite-app bot commented Mar 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Mar 29, 2025
@gregfromstl gregfromstl merged commit 0121ccd into main Mar 29, 2025
18 of 19 checks passed
@gregfromstl gregfromstl deleted the greg/fix-playground-commerce branch March 29, 2025 02:19
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (12bcfc5) to head (2dae647).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6577   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         885      885           
  Lines       55492    55492           
  Branches     3795     3795           
=======================================
  Hits        30517    30517           
  Misses      24880    24880           
  Partials       95       95           
Flag Coverage Δ
packages 54.99% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (-0.02% 🔽) 952 ms (-0.02% 🔽) 154 ms (+179.13% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 235 ms (+49.41% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 95 ms (+1376.38% 🔺) 207 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 55 ms (+3715.75% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 94 ms (+393.28% 🔺) 481 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant