Skip to content

Fix: Not Found Status should show Pending #6578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 29, 2025


PR-Codex overview

This PR focuses on fixing a bug in the OnRampScreen.tsx file related to the handling of different UI statuses during the payment process.

Detailed summary

  • Updated the case structure for handling payment statuses in OnRampScreen.tsx.
  • Changed the handling of the FAILED case to ensure it correctly sets uiStatus to "failed".
  • Adjusted the PENDING case to set uiStatus to "pending" when the NOT_FOUND case is encountered.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners March 29, 2025 03:06
Copy link

changeset-bot bot commented Mar 29, 2025

🦋 Changeset detected

Latest commit: 14d92f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 3:21am
login 🛑 Canceled (Inspect) Mar 29, 2025 3:21am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 3:21am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 3:21am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 3:21am

Copy link
Contributor

graphite-app bot commented Mar 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 29, 2025
@gregfromstl gregfromstl force-pushed the greg/fix-not-found-status branch from 0112cfb to 14d92f2 Compare March 29, 2025 03:07
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 29, 2025
Copy link
Member Author

gregfromstl commented Mar 29, 2025

Merge activity

  • Mar 28, 11:10 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 28, 11:12 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 28, 11:16 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 28, 11:17 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 206 ms (+142.56% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 333 ms (+31.3% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 101 ms (+1214.31% 🔺) 213 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 78 ms (+2643.47% 🔺) 88 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 121 ms (+452.95% 🔺) 508 ms

@gregfromstl gregfromstl merged commit 2a1f4be into main Mar 29, 2025
25 of 28 checks passed
@gregfromstl gregfromstl deleted the greg/fix-not-found-status branch March 29, 2025 03:11
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (0121ccd) to head (14d92f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6578   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         885      885           
  Lines       55492    55492           
  Branches     3795     3795           
=======================================
  Hits        30517    30517           
  Misses      24880    24880           
  Partials       95       95           
Flag Coverage Δ
packages 54.99% <0.00%> (ø)
Files with missing lines Coverage Δ
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 5.77% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants