Skip to content

[TOOL-3839] Fix double scrollbars in project settings page #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 29, 2025

PR-Codex overview

This PR modifies the className property in the SidebarLayout component to include an additional relative class, enhancing the layout's styling.

Detailed summary

  • Updated className in the div element:
    • Added relative class to the existing classes.
  • Maintained the inclusion of props.className.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 29, 2025

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 29, 2025 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 29, 2025 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 29, 2025 07:42 Inactive
Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 7:57am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 29, 2025 7:57am
login ⬜️ Skipped (Inspect) Mar 29, 2025 7:57am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 29, 2025 7:57am
wallet-ui ⬜️ Skipped (Inspect) Mar 29, 2025 7:57am

Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: 35c5f57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 29, 2025 07:42 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 29, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 29, 2025 07:42
@MananTank MananTank requested review from a team as code owners March 29, 2025 07:42
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Mar 29, 2025 — with Graphite App
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (2a1f4be) to head (35c5f57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6579   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         885      885           
  Lines       55492    55492           
  Branches     3795     3795           
=======================================
  Hits        30517    30517           
  Misses      24880    24880           
  Partials       95       95           
Flag Coverage Δ
packages 54.99% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 147 ms (+135.39% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 218 ms (+24.99% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 71 ms (+1518.02% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+3477.11% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 93 ms (+831.3% 🔺) 480 ms

Copy link
Contributor

graphite-app bot commented Mar 29, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 29, 2025 07:51 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 29, 2025 07:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 29, 2025 07:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 29, 2025 07:51 Inactive
@graphite-app graphite-app bot merged commit 35c5f57 into main Mar 29, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3839 branch March 29, 2025 07:58
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Mar 29, 2025
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 29, 2025 07:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants