[TOOL-4336] Dashboard: Fix contracts on custom chains not shown in contracts table #6916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6916 +/- ##
==========================================
- Coverage 55.11% 55.10% -0.01%
==========================================
Files 896 896
Lines 57192 57192
Branches 3957 3957
==========================================
- Hits 31520 31516 -4
- Misses 25575 25579 +4
Partials 97 97
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
approved these changes
May 1, 2025
Merge activity
|
…ntracts table (#6916) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the chain fetching functionality within the application. It renames and updates the `getChains` function to `getChainsForNebula`, introduces a new utility `fetchChainWithLocalOverrides`, and modifies various components to utilize these changes. ### Detailed summary - Renamed `getChains` to `getChainsForNebula` in `getChainIds.ts`. - Updated references to `getChains` in `page.tsx` and `login/page.tsx` to use `getChainsForNebula`. - Introduced `fetchChainWithLocalOverrides` in `fetchChainWithLocalOverrides.ts`. - Replaced `fetchChain` with `fetchChainWithLocalOverrides` in `getSortedDeployedContracts.tsx` and `getContractFromParams.ts`. - Removed redundant local chain fetching logic from `getContractFromParams.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
tool-4336
branch
from
9716ca8 to
004f377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on renaming and refactoring the
getChainsfunction togetChainsForNebulaand updating its usage across various components. Additionally, it introduces a new utility function,fetchChainWithLocalOverrides, to enhance chain fetching with local overrides.Detailed summary
getChainstogetChainsForNebulaingetChainIds.ts.getChainstogetChainsForNebulain:page.tsxof the login component.page.tsxof the main app page.fetchChainWithLocalOverridesinfetchChainWithLocalOverrides.tsfor enhanced chain fetching.getSortedDeployedContractsto usefetchChainWithLocalOverrides.fetchChainwithfetchChainWithLocalOverridesingetContractFromParams.ts.