-
Notifications
You must be signed in to change notification settings - Fork 544
[SDK] Optimize token balance fetching with Insight API #6923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Optimize token balance fetching with Insight API #6923
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (8.37%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6923 +/- ##
==========================================
- Coverage 55.09% 55.03% -0.07%
==========================================
Files 896 897 +1
Lines 57193 57296 +103
Branches 3955 3959 +4
==========================================
+ Hits 31511 31530 +19
- Misses 25585 25670 +85
+ Partials 97 96 -1
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on enhancing the insight capabilities in the
thirdweb
package by introducing new functionality to check if insights are enabled for specific chains and refactoring the token balance fetching mechanism to utilize this feature.Detailed summary
isInsightEnabled
function to check if the "insight" service is enabled for a chain.createSupportedTokens
to filter out tokens with theZERO_ADDRESS
.fetchBalancesForWallet
to consolidate balance fetching logic.