Skip to content

[Changeset] Optimize token query in PayEmbed with Insight #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 2, 2025


PR-Codex overview

This PR focuses on optimizing the token query within the PayEmbed component by utilizing Insight where applicable, which aims to enhance performance and efficiency.

Detailed summary

  • Introduced an optimization for the token query in the PayEmbed component.
  • Leveraged Insight to streamline the querying process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 2:57am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 2:57am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 2:57am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 2:57am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 2:57am

Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 3b9c340

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [SDK] Optimize token query in PayEmbed with Insight [Changeset] Optimize token query in PayEmbed with Insight May 2, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review May 2, 2025 02:49
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (a96fa91) to head (3b9c340).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6924   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         897      897           
  Lines       57296    57296           
  Branches     3959     3959           
=======================================
  Hits        31530    31530           
  Misses      25670    25670           
  Partials       96       96           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 20d182b into main May 2, 2025
20 of 25 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Optimize_token_query_in_PayEmbed_with_Insight branch May 2, 2025 02:50
@joaquim-verges joaquim-verges mentioned this pull request May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.93 KB (0%) 1.1 s (0%) 242 ms (+135.42% 🔺) 1.3 s
thirdweb (cjs) 143.02 KB (0%) 2.9 s (0%) 423 ms (+63.2% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 85 ms (+810.1% 🔺) 199 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 37 ms (+1340.24% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 95 ms (+338.4% 🔺) 484 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant