-
Notifications
You must be signed in to change notification settings - Fork 543
[TOOL-4354] Nebula: Configure erc20Value for swap prepared transaction #6926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6926 +/- ##
=======================================
Coverage 55.03% 55.03%
=======================================
Files 897 897
Lines 57296 57296
Branches 3959 3959
=======================================
Hits 31530 31530
Misses 25670 25670
Partials 96 96
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
#6926) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces logic to handle transactions involving native tokens in the `SwapTransactionCardLayout` component. It determines if the transaction involves selling a native token and adjusts the transaction data accordingly. ### Detailed summary - Added a constant `isSellingNativeToken` to check if the transaction involves selling the native token. - Updated the transaction object to conditionally set `erc20Value` based on whether the native token is being sold. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
fa6e5c3
to
4839173
Compare
PR-Codex overview
This PR introduces logic to handle transactions involving the native token in the
SwapTransactionCardLayout
component. It determines if the user is selling the native token and adjusts the transaction data accordingly.Detailed summary
NATIVE_TOKEN_ADDRESS
andgetAddress
imports fromthirdweb
.isSellingNativeToken
to check if the transaction involves the native token.tx
object to conditionally seterc20Value
based on whether the user is selling the native token.