Skip to content

[TOOL-4354] Nebula: Configure erc20Value for swap prepared transaction #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 2, 2025


PR-Codex overview

This PR introduces logic to handle transactions involving the native token in the SwapTransactionCardLayout component. It determines if the user is selling the native token and adjusts the transaction data accordingly.

Detailed summary

  • Added NATIVE_TOKEN_ADDRESS and getAddress imports from thirdweb.
  • Defined isSellingNativeToken to check if the transaction involves the native token.
  • Updated the tx object to conditionally set erc20Value based on whether the user is selling the native token.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented May 2, 2025

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 4839173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 3:11pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 2, 2025 3:11pm
login ⬜️ Skipped (Inspect) May 2, 2025 3:11pm
thirdweb_playground ⬜️ Skipped (Inspect) May 2, 2025 3:11pm
wallet-ui ⬜️ Skipped (Inspect) May 2, 2025 3:11pm

@MananTank MananTank marked this pull request as ready for review May 2, 2025 13:01
@MananTank MananTank requested review from a team as code owners May 2, 2025 13:01
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 2, 2025
Copy link
Member Author

MananTank commented May 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (1e82083) to head (4839173).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6926   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         897      897           
  Lines       57296    57296           
  Branches     3959     3959           
=======================================
  Hits        31530    31530           
  Misses      25670    25670           
  Partials       96       96           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.95 KB (+0.04% 🔺) 1.1 s (+0.04% 🔺) 244 ms (+152.3% 🔺) 1.3 s
thirdweb (cjs) 143.02 KB (0%) 2.9 s (0%) 378 ms (+40% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 100 ms (+1164.3% 🔺) 213 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 23 ms (+179.51% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 104 ms (+442.12% 🔺) 493 ms

Copy link
Contributor

graphite-app bot commented May 2, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from neb-229 to graphite-base/6926 May 2, 2025 14:56
@graphite-app graphite-app bot changed the base branch from graphite-base/6926 to main May 2, 2025 15:03
#6926)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces logic to handle transactions involving native tokens in the `SwapTransactionCardLayout` component. It determines if the transaction involves selling a native token and adjusts the transaction data accordingly.

### Detailed summary
- Added a constant `isSellingNativeToken` to check if the transaction involves selling the native token.
- Updated the transaction object to conditionally set `erc20Value` based on whether the native token is being sold.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 15:04 Inactive
@graphite-app graphite-app bot merged commit 4839173 into main May 2, 2025
23 checks passed
@graphite-app graphite-app bot deleted the tool-4354 branch May 2, 2025 15:12
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 2, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – login May 2, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 2, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 2, 2025 15:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants