Skip to content

[TOOL-4292] Dashboard: Show Team selector page for '~' team slug #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 2, 2025


PR-Codex overview

This PR primarily focuses on refactoring the handling of team selection in the dashboard. It removes old redirection logic and introduces a new page for selecting a team when multiple teams are present.

Detailed summary

  • Removed old redirection logic for /team/~/....
  • Added new Page component for team selection.
  • Implemented fetching of teams and authentication token.
  • Added UI elements for team selection, including TeamHeader, GradientAvatar, and TeamPlanBadge.
  • Introduced createTeamLink function to generate team-specific links.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 20:13 Inactive
Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 10:06pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 2, 2025 10:06pm
login ⬜️ Skipped (Inspect) May 2, 2025 10:06pm
thirdweb_playground ⬜️ Skipped (Inspect) May 2, 2025 10:06pm
wallet-ui ⬜️ Skipped (Inspect) May 2, 2025 10:06pm

Copy link

linear bot commented May 2, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 20:13 Inactive
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 80bf795

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 20:13 Inactive
@MananTank MananTank marked this pull request as ready for review May 2, 2025 20:13
@MananTank MananTank requested review from a team as code owners May 2, 2025 20:13
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 2, 2025
Copy link
Member Author

MananTank commented May 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (7ae174f) to head (80bf795).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6930   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         897      897           
  Lines       57296    57296           
  Branches     3959     3959           
=======================================
  Hits        31530    31530           
  Misses      25670    25670           
  Partials       96       96           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.93 KB (0%) 1.1 s (0%) 328 ms (+207.74% 🔺) 1.4 s
thirdweb (cjs) 143.02 KB (0%) 2.9 s (0%) 521 ms (+78.41% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 164 ms (+2303.97% 🔺) 278 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 31 ms (+630.1% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 177 ms (+871.43% 🔺) 566 ms

@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 20:46 Inactive
@MananTank MananTank requested a review from jnsdls May 2, 2025 21:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 21:52 Inactive
Copy link
Contributor

graphite-app bot commented May 2, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR removes a redirect feature for team paths in the `middleware.ts` file and introduces a new page component in `page.tsx` that allows users to select a team when they belong to multiple teams, enhancing the team selection experience.

### Detailed summary
- Removed redirect logic for `/team/~/...` paths in `middleware.ts`.
- Added a new page component in `page.tsx` for team selection.
- Implemented fetching of teams and authentication token using `Promise.all`.
- Included UI elements for displaying teams and their details.
- Introduced `createTeamLink` function to generate team-specific links.
- Utilized components like `GradientAvatar`, `TeamHeader`, and `AppFooter` for layout.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 22:00 Inactive
@graphite-app graphite-app bot merged commit 80bf795 into main May 2, 2025
23 checks passed
@graphite-app graphite-app bot deleted the tool-4292 branch May 2, 2025 22:07
@vercel vercel bot temporarily deployed to Production – docs-v2 May 2, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 2, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 2, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – login May 2, 2025 22:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants