-
Notifications
You must be signed in to change notification settings - Fork 542
[SDK] Handle Hedera native currency decimals for smart wallet calls #6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Handle Hedera native currency decimals for smart wallet calls #6969
Conversation
🦋 Changeset detectedLatest commit: a2bc3f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
a520b20
to
a2bc3f3
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (36.36%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6969 +/- ##
==========================================
- Coverage 55.03% 55.02% -0.01%
==========================================
Files 898 898
Lines 57347 57352 +5
Branches 3966 3965 -1
==========================================
- Hits 31561 31560 -1
- Misses 25689 25693 +4
- Partials 97 99 +2
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR introduces adjustments to handle the decimal values of native currency for smart wallet calls specifically for hedera chains, ensuring compatibility in contract transactions.
Detailed summary
expect
statement to check ifnft.owner
is defined instead of a specific address.nft.owner
value in the inline snapshot.packages/thirdweb/src/wallets/smart/lib/calls.ts
:transaction.value
by dividing it for specific chain IDs (295 and 296).