Dashboard: Fix team links in header on pages outside /team layout #6981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
force-pushed
the
05-09-dashboard_fix_team_links_in_header_on_pages_outside__team_layout
branch
from
c1489a5 to
377fb4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6981 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 903 903
Lines 57934 57934
Branches 3970 3970
=======================================
Hits 31632 31632
Misses 26202 26202
Partials 100 100
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
approved these changes
May 8, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 8, 2025
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR modifies the `href` attribute of a `Link` component in the `TeamSelectionUI.tsx` file to ensure that the URL is correctly updated when navigating between teams, specifically when on the `/team` page. ### Detailed summary - Updated the `href` logic in the `Link` component. - Added a condition to check if `pathname` starts with `/team`. - Changed the replacement logic to include the `/team/` prefix for both `currentTeam` and `team`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
05-09-dashboard_fix_team_links_in_header_on_pages_outside__team_layout
branch
from
377fb4c to
75163ec
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/app/(app)/team/components/TeamHeader/TeamSelectionUI.tsx
Show resolved
Hide resolved
MananTank
added a commit
that referenced
this pull request
May 9, 2025
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR modifies the `href` attribute of a `Link` component in the `TeamSelectionUI.tsx` file to ensure that the URL is correctly updated when navigating between teams, specifically when on the `/team` page. ### Detailed summary - Updated the `href` logic in the `Link` component. - Added a condition to check if `pathname` starts with `/team`. - Changed the replacement logic to include the `/team/` prefix for both `currentTeam` and `team`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
05-09-dashboard_fix_team_links_in_header_on_pages_outside__team_layout
branch
from
75163ec to
faf22f1
Compare
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR modifies the `href` attribute of the `Link` component in the `TeamSelectionUI.tsx` file to ensure that the URL path is correctly constructed when navigating between team pages. ### Detailed summary - Updated the `href` logic to check if `pathname` starts with `/team`. - Changed the `replace` method to use the full path for `currentTeam.slug` and `team.slug`. - Ensured that the fallback URL for the `Link` defaults to `/team/${team.slug}` when conditions are not met. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
05-09-dashboard_fix_team_links_in_header_on_pages_outside__team_layout
branch
from
faf22f1 to
ccb9cd5
Compare
graphite-app
bot
deleted the
05-09-dashboard_fix_team_links_in_header_on_pages_outside__team_layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
hrefproperty of theLinkcomponent in theTeamSelectionUI.tsxfile to ensure it correctly replaces the team slug in the URL only when certain conditions are met.Detailed summary
hrefproperty of theLinkcomponent.pathnamestarts with/teambefore replacing the current team slug.