Skip to content

Fix: Trend badge formatting #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 10, 2025


PR-Codex overview

This PR focuses on updating the calculation of percentage changes and formatting for better clarity in the Payouts, common, and PayNewCustomers components.

Detailed summary

  • In Payouts.tsx, updated the trend calculation to handle cases where lastPeriod.value is 0, returning 100 instead of performing division.
  • In common.tsx, replaced the display of percentValue with a formatted string using Intl.NumberFormat to show percentage without decimal places.
  • In PayNewCustomers.tsx, similar trend calculation adjustment as in Payouts.tsx to improve handling of zero values.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 10, 2025 17:08
Copy link

vercel bot commented May 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 5:15pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 5:15pm
login ⬜️ Skipped (Inspect) May 10, 2025 5:15pm
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 5:15pm
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 5:15pm

Copy link

changeset-bot bot commented May 10, 2025

⚠️ No Changeset found

Latest commit: fea3688

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented May 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 10, 2025
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label May 10, 2025
Copy link
Member Author

Merge activity

  • May 10, 1:09 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (7de273c) to head (fea3688).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7007   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         903      903           
  Lines       57936    57936           
  Branches     3971     3971           
=======================================
  Hits        31638    31638           
  Misses      26197    26197           
  Partials      101      101           
Flag Coverage Δ
packages 54.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 161 ms (+121.42% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 348 ms (+30.68% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 58 ms (+1037.19% 🔺) 172 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 37 ms (+1609.72% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 58 ms (+402.23% 🔺) 449 ms

@gregfromstl gregfromstl merged commit ff565cb into main May 10, 2025
24 checks passed
@gregfromstl gregfromstl deleted the greg/fix-trend-badge-formatting branch May 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant