Skip to content

Fix: Auto-signin to autoconnect for all cases #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 11, 2025


PR-Codex overview

This PR focuses on implementing auto-login functionality for an in-app wallet (IAW) when connecting, ensuring that users are logged in automatically under specified conditions.

Detailed summary

  • Updated the siweAuth type to include isLoggedIn and isLoggingIn properties.
  • Introduced a check for isIAW to determine if the active wallet is an in-app signer.
  • Modified the auto-connect logic to trigger doLogin if authentication is required and the user is not already logged in or logging in.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 11, 2025 21:15
Copy link

linear bot commented May 11, 2025

Copy link

changeset-bot bot commented May 11, 2025

🦋 Changeset detected

Latest commit: bab2088

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:32pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:32pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:32pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:32pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:32pm

Copy link
Contributor

graphite-app bot commented May 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented May 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 269 ms (+65.37% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 676 ms (+2.53% 🔺) 4.6 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 100 ms (+585.74% 🔺) 214 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 28 ms (+707.29% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 50 ms (+92.65% 🔺) 441 ms

Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (5a13ad4) to head (bab2088).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...thirdweb/src/wallets/connection/autoConnectCore.ts 53.33% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (53.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7011      +/-   ##
==========================================
+ Coverage   54.60%   54.63%   +0.02%     
==========================================
  Files         904      904              
  Lines       57960    57974      +14     
  Branches     3969     3977       +8     
==========================================
+ Hits        31648    31673      +25     
+ Misses      26211    26201      -10     
+ Partials      101      100       -1     
Flag Coverage Δ
packages 54.63% <53.33%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...thirdweb/src/wallets/connection/autoConnectCore.ts 83.22% <53.33%> (-2.59%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl deleted the greg/tool-4452-telegram-redirect-login-on-ios-embedded-browsers branch May 11, 2025 21:41
@joaquim-verges joaquim-verges mentioned this pull request May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant