You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances error handling during the login process by adding a catch block to the doLogin method, ensuring that any errors are logged without interrupting the auto-connection flow.
Detailed summary
Added a catch block to props.siweAuth?.doLogin() to handle potential errors.
Logged a warning message with the error details using console.warn.
Ensured that manager.isAutoConnecting.setValue(false) is called regardless of login success.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
merge-queueAdds the pull request to Graphite's merge queue.packagesSDKInvolves changes to the thirdweb SDK
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gregfromstl
added
the
merge-queue
joaquim-verges
deleted the
greg/tool-4452-telegram-redirect-login-on-ios-embedded-browsers
branch
PR-Codex overview
This PR enhances error handling during the login process by adding a catch block to the
doLoginmethod, ensuring that any errors are logged without interrupting the auto-connection flow.Detailed summary
catchblock toprops.siweAuth?.doLogin()to handle potential errors.console.warn.manager.isAutoConnecting.setValue(false)is called regardless of login success.