[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141

MananTank · 2025-05-23T14:17:57Z

PR-Codex overview

This PR updates the import path for the resolveImplementation function in the resolveImplementation.ts file to reflect its new location within the thirdweb/utils directory.

Detailed summary

Changed the import statement for resolveImplementation from:
- import { resolveImplementation } from "thirdweb";
- to import { resolveImplementation } from "thirdweb/utils";

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Documentation
- Updated example import path in documentation for improved clarity.

linear · 2025-05-23T14:18:01Z

TOOL-4591 Review issue with auto-reference documentation and SDK export

vercel · 2025-05-23T14:18:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 5:19pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 5:19pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 5:19pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 5:19pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 5:19pm

changeset-bot · 2025-05-23T14:18:02Z

⚠️ No Changeset found

Latest commit: 916ecf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-23T14:18:05Z

Walkthrough

The only modification in this change is an update to the JSDoc example import path for the resolveImplementation function, changing it from "thirdweb" to "thirdweb/utils". No code logic, exports, or control flow have been altered.

Changes

File(s)	Change Summary
packages/thirdweb/src/utils/bytecode/resolveImplementation.ts	Updated JSDoc example import path for `resolveImplementation`

Assessment against linked issues

Objective	Addressed	Explanation
Review issue with auto-reference documentation and SDK export path for `resolveImplementation` ([TOOL-4591])	✅

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc92e15 and 916ecf4.

📒 Files selected for processing (1)

packages/thirdweb/src/utils/bytecode/resolveImplementation.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/thirdweb/src/utils/bytecode/resolveImplementation.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Size
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MananTank · 2025-05-23T14:18:11Z

[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/thirdweb/src/utils/bytecode/resolveImplementation.ts (1)

21-21: Update JSDoc example import path
The import path in the JSDoc example has been corrected to "thirdweb/utils", matching the actual location of resolveImplementation.
Please verify that any other documentation or code samples (e.g., README, tutorials) are updated to use this new path as well.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 317211a and cc92e15.

📒 Files selected for processing (1)

packages/thirdweb/src/utils/bytecode/resolveImplementation.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Build Packages
GitHub Check: Lint Packages
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Size
GitHub Check: Analyze (javascript)

github-actions · 2025-05-23T14:23:41Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	56.62 KB (0%)	1.2 s (0%)	221 ms (+129.2% 🔺)	1.4 s
thirdweb (cjs)	309.13 KB (0%)	6.2 s (0%)	885 ms (+6.25% 🔺)	7.1 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	58 ms (+705.03% 🔺)	172 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	17 ms (+487.5% 🔺)	27 ms
thirdweb/react (minimal + tree-shaking)	19.5 KB (0%)	390 ms (0%)	92 ms (+503.94% 🔺)	482 ms

codecov · 2025-05-23T14:24:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (d1ca9af) to head (916ecf4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7141      +/-   ##
==========================================
- Coverage   55.63%   55.62%   -0.01%     
==========================================
  Files         902      902              
  Lines       58190    58190              
  Branches     4098     4098              
==========================================
- Hits        32373    32369       -4     
- Misses      25712    25716       +4     
  Partials      105      105

Flag	Coverage Δ
packages	`55.62% <ø> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
...irdweb/src/utils/bytecode/resolveImplementation.ts	`80.14% <ø> (ø)`

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-05-23T17:11:27Z

Merge activity

May 23, 5:11 PM UTC: MananTank added this pull request to the Graphite merge queue.
May 23, 5:19 PM UTC: Merged by the Graphite merge queue.

)   --- ## PR-Codex overview This PR updates the import path for the `resolveImplementation` function to reflect its new location within the `thirdweb/utils` directory. ### Detailed summary - Changed import statement for `resolveImplementation` from `thirdweb` to `thirdweb/utils`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **Documentation** - Updated example import path in documentation for improved clarity.

MananTank marked this pull request as ready for review May 23, 2025 14:18

MananTank requested review from a team as code owners May 23, 2025 14:18

github-actions bot assigned MananTank May 23, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 23, 2025

coderabbitai bot reviewed May 23, 2025

View reviewed changes

MananTank changed the title ~~[TOOL-4591] Fix resolveImplementation jsdoc code example~~ [TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc May 23, 2025

vercel bot deployed to Preview – wallet-ui May 23, 2025 14:20 View deployment

vercel bot deployed to Preview – login May 23, 2025 14:20 View deployment

vercel bot deployed to Preview – thirdweb_playground May 23, 2025 14:21 View deployment

vercel bot deployed to Preview – thirdweb-www May 23, 2025 14:26 View deployment

vercel bot deployed to Preview – docs-v2 May 23, 2025 14:28 View deployment

joaquim-verges approved these changes May 23, 2025

View reviewed changes

graphite-app bot force-pushed the 05-23-_tool-4591_fix_resolveimplementation_jsdoc_code_example branch from cc92e15 to 916ecf4 Compare May 23, 2025 17:11

vercel bot deployed to Preview – thirdweb_playground May 23, 2025 17:12 View deployment

vercel bot deployed to Preview – wallet-ui May 23, 2025 17:13 View deployment

vercel bot deployed to Preview – docs-v2 May 23, 2025 17:13 View deployment

vercel bot deployed to Preview – login May 23, 2025 17:13 View deployment

vercel bot deployed to Preview – thirdweb-www May 23, 2025 17:19 View deployment

graphite-app bot merged commit 916ecf4 into main May 23, 2025
24 checks passed

graphite-app bot deleted the 05-23-_tool-4591_fix_resolveimplementation_jsdoc_code_example branch May 23, 2025 17:19

vercel bot deployed to Production – login May 23, 2025 17:21 View deployment

vercel bot deployed to Production – wallet-ui May 23, 2025 17:21 View deployment

vercel bot deployed to Production – thirdweb_playground May 23, 2025 17:22 View deployment

vercel bot deployed to Production – docs-v2 May 23, 2025 17:27 View deployment

vercel bot deployed to Production – thirdweb-www May 23, 2025 17:28 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141

[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141

Uh oh!

MananTank commented May 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented May 23, 2025

Uh oh!

vercel bot commented May 23, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 23, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MananTank commented May 23, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented May 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 23, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141

[TOOL-4591] Fix resolveImplementation jsdoc code example in jsdoc #7141

Uh oh!

Conversation

MananTank commented May 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

linear bot commented May 23, 2025

Uh oh!

vercel bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MananTank commented May 23, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented May 23, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 23, 2025 •

edited

Loading

changeset-bot bot commented May 23, 2025 •

edited

Loading

coderabbitai bot commented May 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented May 23, 2025 •

edited

Loading

codecov bot commented May 23, 2025 •

edited

Loading

graphite-app bot commented May 23, 2025 •

edited

Loading