Skip to content

[Dashboard] Change "Network" label to "Select Testnet" in analytics test transaction form #7178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 27, 2025

Fixes TOOL-4596
Fixes TOOL-4592


PR-Codex overview

This PR updates the user interface for selecting a network in the send-test-tx.client.tsx file. It changes the label from "Network" to "Select Testnet" to provide clearer instructions for users.

Detailed summary

  • Changed the text from <p className="text-sm">Network</p> to <p className="text-sm">Select Testnet</p> in send-test-tx.client.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Updated the label above the network selector dropdown from "Network" to "Select Testnet."
    • Revised informational links in the platform fee section to direct users to the pricing page with updated anchor text for clearer fee breakdown details.

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 11:55pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 27, 2025 11:55pm
login ⬜️ Skipped (Inspect) May 27, 2025 11:55pm
thirdweb_playground ⬜️ Skipped (Inspect) May 27, 2025 11:55pm
wallet-ui ⬜️ Skipped (Inspect) May 27, 2025 11:55pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 23:42 Inactive
Copy link

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: f366e70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 27, 2025 23:42 Inactive
Copy link
Contributor

coderabbitai bot commented May 27, 2025

Walkthrough

A single text label above the network selector dropdown was updated from "Network" to "Select Testnet" in the relevant client-side component. Additionally, two external links in the PlatformFeeFieldset component were updated to point to a pricing page with revised anchor text. No functional or logic changes were made.

Changes

File Path Change Summary
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/cloud/analytics/send-test-tx.client.tsx Updated label text above network selector
apps/dashboard/src/components/contract-components/contract-deploy-form/platform-fee-fieldset.tsx Updated external links and anchor text in PlatformFeeFieldset

Assessment against linked issues

Objective Addressed Explanation
Use Engine Cloud on chains not listed in dashboard (TOOL-4596) Changes only update UI text and links; no implementation related to Engine Cloud chain usage

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9eec2a1 and f366e70.

📒 Files selected for processing (2)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/cloud/analytics/send-test-tx.client.tsx (1 hunks)
  • apps/dashboard/src/components/contract-components/contract-deploy-form/platform-fee-fieldset.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/dashboard/src/components/contract-components/contract-deploy-form/platform-fee-fieldset.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/cloud/analytics/send-test-tx.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joaquim-verges joaquim-verges marked this pull request as ready for review May 27, 2025 23:42
@joaquim-verges joaquim-verges requested review from a team as code owners May 27, 2025 23:42
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 27, 2025
Copy link
Member Author

joaquim-verges commented May 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.66%. Comparing base (e14a134) to head (f366e70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7178   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         904      904           
  Lines       58391    58391           
  Branches     4114     4114           
=======================================
  Hits        32504    32504           
  Misses      25781    25781           
  Partials      106      106           
Flag Coverage Δ
packages 55.66% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Change_Network_label_to_Select_Testnet_in_analytics_test_transaction_form branch from 9eec2a1 to f366e70 Compare May 27, 2025 23:45
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 23:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 27, 2025 23:45 Inactive
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 61.75 KB (0%) 1.3 s (0%) 250 ms (+123.06% 🔺) 1.5 s
thirdweb (cjs) 344.4 KB (0%) 6.9 s (0%) 846 ms (-7.08% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 105 ms (+1499.39% 🔺) 219 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 18 ms (+550.37% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 96 ms (+530.55% 🔺) 487 ms

@joaquim-verges joaquim-verges merged commit 8ed5ef3 into main May 28, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Change_Network_label_to_Select_Testnet_in_analytics_test_transaction_form branch May 28, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant