-
Notifications
You must be signed in to change notification settings - Fork 543
chore: annotate getBuyWithFiatQuote as deprecated #7198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: annotate getBuyWithFiatQuote as deprecated #7198
Conversation
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughA Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@RobbyUitbeijerse is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
Since the param type
GetBuyWithFiatQuoteParams
and wrapping hookuseBuyWithFiatQuote
are marked as deprecated, and we were explicitly advised to use theBridge.Onramp.prepare
, I thinkgetBuyWithFiatQuote
should be marked as deprecated too. Unless there's very specific purpose for it not being marked as such already, in that case please ignore!PR-Codex overview
This PR introduces a deprecation notice for the
getBuyWithFiatQuote
function and adds an annotation for its usage.Detailed summary
@deprecated
annotation to thegetBuyWithFiatQuote
function.@buyCrypto
annotation for further context on the function's purpose.Summary by CodeRabbit