Update ecosystem FAQ #7204
Update ecosystem FAQ #7204
Conversation
Signed-off-by: Joaquim Verges <joaquim.verges@gmail.com>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe documentation was updated to reflect that WalletConnect and wagmi- or viem-based login providers are now supported for displaying the Ecosystem Wallet, removing previous language that indicated these features were "coming soon." Changes
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
the
Portal
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/app/connect/wallet/ecosystem/faq/page.mdx (1)
30-30: Confirm immediate support for WalletConnect and wagmi/viem providersYou’ve removed “coming soon” to indicate these providers are now supported. Please verify that the current release indeed supports displaying the Ecosystem Wallet with WalletConnect and any wagmi- or viem-based login providers. If not, consider reverting or clarifying the timeline.
For grammatical consistency, consider adding an Oxford comma:
“thirdweb Connect, WalletConnect, and any wagmi- or viem-based login providers.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/portal/src/app/connect/wallet/ecosystem/faq/page.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7204 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 904 904
Lines 58392 58392
Branches 4122 4122
=======================================
Hits 32516 32516
Misses 25770 25770
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR focuses on updating the text in the
page.mdxfile to improve clarity regarding the login providers for the Ecosystem Wallet.Detailed summary
Summary by CodeRabbit