Fix requests to thirdwebstorage-dev.com not set with secret-key #7205
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughA new domain string ".thirdwebstorage-dev.com" was added to the array of recognized thirdweb service domains in the fetch utility file. No other logic, control flow, or exported entities were changed. Changes
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/src/utils/fetch.ts (1)
130-130: Add test coverage for the new storage dev domain.You’ve correctly added
.thirdwebstorage-dev.comtoTHIRDWEB_DOMAINS. To guard against regressions, please add unit tests forisThirdwebUrlthat assert URLs ending with this new suffix returntrue.Example Jest snippet:
import { isThirdwebUrl } from "../utils/fetch"; test("recognizes .thirdwebstorage-dev.com as a thirdweb URL", () => { expect(isThirdwebUrl("https://cdn.thirdwebstorage-dev.com/files/abc")).toBe(true); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/thirdweb/src/utils/fetch.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7205 +/- ##
==========================================
- Coverage 55.68% 55.67% -0.01%
==========================================
Files 904 904
Lines 58392 58393 +1
Branches 4122 4120 -2
==========================================
- Hits 32516 32511 -5
- Misses 25770 25776 +6
Partials 106 106
🚀 New features to boost your workflow:
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `fetch.ts` file in the `thirdweb` package to include a new URL for the thirdweb storage service.
### Detailed summary
- Added `".thirdwebstorage-dev.com"` to the list of URLs.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Chores**
- Updated the list of recognized thirdweb service domains to include ".thirdwebstorage-dev.com".
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
05-30-fix_requests_to_thirdwebstorage-dev.com_not_set_with_secret-key
branch
from
d52154e to
6a335bf
Compare
graphite-app
bot
deleted the
05-30-fix_requests_to_thirdwebstorage-dev.com_not_set_with_secret-key
branch
PR-Codex overview
This PR introduces a new URL to the list of constants in the
fetch.tsfile, which likely pertains to thirdweb's storage capabilities.Detailed summary
".thirdwebstorage-dev.com"to the array of constants.Summary by CodeRabbit