Version Packages #7207
Version Packages #7207
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis update introduces new server wallet management and transaction search features to the Engine module, including methods for creating and retrieving server wallets, searching transactions with advanced filters, batch transaction support, and improved error reporting. It also updates package versions and changelogs across multiple packages. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Engine
participant ServerWallet
Client->>Engine: createServerWallet({label})
Engine-->>Client: ServerWallet instance
Client->>Engine: getServerWallets()
Engine-->>Client: List of ServerWallets
Client->>Engine: searchTransactions({filters, pagination})
Engine-->>Client: List of Transactions
Client->>ServerWallet: enqueueBatchTransaction({transactions})
ServerWallet-->>Client: { transactionId }
Client->>Engine: waitForTransactionHash({transactionId})
Engine-->>Client: { transactionHash }
Possibly related PRs
Suggested labels
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
packages/engine/CHANGELOG.md (1)
7-7: Add missing punctuation in changelog entry
For consistency and clarity, append a period at the end of the patch description.-Updated to latest API +Updated to latest API.🧰 Tools
🪛 LanguageTool
[uncategorized] ~7-~7: A punctuation mark might be missing here.
Context: ...//github.com//pull/7190) [861e623](https://github.com/thirdweb-d...(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/thirdweb/CHANGELOG.md (1)
7-8: Consider splitting the PR summary line for readability
The single-line bullet for PR [#7190] is quite long. Splitting the description across two lines can improve readability in the changelog.- - [#7190](https://github.com/thirdweb-dev/js/pull/7190) [`861e623`](https://github.com/thirdweb-dev/js/commit/861e623a1b7519bcac09c0c6d975cad2c0c5be4f) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Enhanced Engine functionality with server wallet management, search transactions and batch transaction support: + - [#7190](https://github.com/thirdweb-dev/js/pull/7190) [`861e623`](https://github.com/thirdweb-dev/js/commit/861e623a1b7519bcac09c0c6d975cad2c0c5be4f) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! + Enhanced Engine: server wallet management, transaction search, batch support, and improved error reporting.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.changeset/engine-enhancements.md(0 hunks).changeset/stupid-adults-flow.md(0 hunks)packages/engine/CHANGELOG.md(1 hunks)packages/engine/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/stupid-adults-flow.md
- .changeset/engine-enhancements.md
🧰 Additional context used
🪛 LanguageTool
packages/engine/CHANGELOG.md
[uncategorized] ~7-~7: A punctuation mark might be missing here.
Context: ...//github.com//pull/7190) [861e623](https://github.com/thirdweb-d...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
packages/wagmi-adapter/package.json (1)
3-3: Approve version bump to 0.2.86The version has been correctly updated from
0.2.85to0.2.86as part of this release.packages/engine/package.json (1)
3-3: Approve version bump to 3.0.3
The package version has been correctly updated from3.0.2to3.0.3, aligning with the new patch release that supports the latest API enhancements.packages/thirdweb/package.json (1)
3-3: Approve version bump to 5.102.0
The SDK version has been correctly updated from5.101.2to5.102.0, reflecting the integration of the new Engine features.packages/thirdweb/CHANGELOG.md (6)
3-6: Confirm semantic version bump
The version header correctly reflects the bump from5.101.2to5.102.0. This aligns with the PR objectives for the new minor release.
9-20: ValidateEngine.createServerWalletexample
The code snippet forEngine.createServerWallet()looks accurate. Ensure that the example aligns exactly with the public API (parameter names, return shape) and will compile in downstream docs.
22-31: ApproveEngine.getServerWalletssnippet
The example forEngine.getServerWallets()is clear and self-contained. Good job illustrating how to list server wallets.
33-68: ApproveEngine.searchTransactionsusage
The filters and pagination examples forsearchTransactions()effectively cover both simple and nested queries. Well-formatted and comprehensive.
97-97: Approve improved error reporting entry
The note about enhanced error reporting for server wallet transactions accurately reflects the underlying changes.
99-102: Confirm dependency update
The bump of@thirdweb-dev/engineto3.0.3under "Patch Changes" matches the API enhancements. Ensure that package manifests and lockfiles are updated accordingly.
| @@ -1,5 +1,11 @@ | |||
| # @thirdweb-dev/insight | |||
|
|
|||
There was a problem hiding this comment.
Fix changelog header to reference the correct package
The header currently reads # @thirdweb-dev/insight but this is the changelog for the Engine package. It should be updated to # @thirdweb-dev/engine.
Apply this diff:
-# @thirdweb-dev/insight
+# @thirdweb-dev/engine📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # @thirdweb-dev/engine |
🤖 Prompt for AI Agents
In packages/engine/CHANGELOG.md at line 2, the changelog header incorrectly
references the package as @thirdweb-dev/insight. Update this header to correctly
reference the Engine package by changing it to # @thirdweb-dev/engine.
| - Added `serverWallet.enqueueBatchTransaction()` to enqueue multiple transactions in a single batch | ||
|
|
||
| ```ts | ||
| // Prepare multiple transactions | ||
| const transaction1 = claimTo({ | ||
| contract, | ||
| to: firstRecipient, | ||
| quantity: 1n, | ||
| }); | ||
| const transaction2 = claimTo({ | ||
| contract, | ||
| to: secondRecipient, | ||
| quantity: 1n, | ||
| }); | ||
|
|
||
| // Enqueue as a batch | ||
| const { transactionId } = await serverWallet.enqueueBatchTransaction({ | ||
| transactions: [transaction1, transaction2], | ||
| }); | ||
|
|
||
| // Wait for batch completion | ||
| const { transactionHash } = await Engine.waitForTransactionHash({ | ||
| client, | ||
| transactionId, | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
Missing changelog entry for waitForTransactionHash
The snippet demonstrates Engine.waitForTransactionHash(), but there's no corresponding bullet under "Minor Changes". This method is a key addition per the PR summary and should be listed.
Please insert a bullet, for example:
- Added `serverWallet.enqueueBatchTransaction()` to enqueue multiple transactions in a single batch
+ - Added `Engine.waitForTransactionHash()` to await batch transaction completion by transaction ID
- Improved server wallet transaction handling with better error reporting📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Added `serverWallet.enqueueBatchTransaction()` to enqueue multiple transactions in a single batch | |
| ```ts | |
| // Prepare multiple transactions | |
| const transaction1 = claimTo({ | |
| contract, | |
| to: firstRecipient, | |
| quantity: 1n, | |
| }); | |
| const transaction2 = claimTo({ | |
| contract, | |
| to: secondRecipient, | |
| quantity: 1n, | |
| }); | |
| // Enqueue as a batch | |
| const { transactionId } = await serverWallet.enqueueBatchTransaction({ | |
| transactions: [transaction1, transaction2], | |
| }); | |
| // Wait for batch completion | |
| const { transactionHash } = await Engine.waitForTransactionHash({ | |
| client, | |
| transactionId, | |
| }); | |
| ``` | |
| - Added `serverWallet.enqueueBatchTransaction()` to enqueue multiple transactions in a single batch | |
| + - Added `Engine.waitForTransactionHash()` to await batch transaction completion by transaction ID |
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md between lines 70 and 95, add a new bullet
point under the "Minor Changes" section to document the addition of the
Engine.waitForTransactionHash() method. This entry should briefly describe the
method's purpose, such as waiting for a transaction hash given a transaction ID,
to align the changelog with the PR summary and code examples.
| ## 0.2.86 | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing changelog entry details for 0.2.86
The new version header is present but does not include any release notes (e.g., dependency bumps or compatibility fixes).
Please populate the 0.2.86 section with a concise summary of changes—or add a “No user-facing changes” note—so consumers can track what changed. For example:
## 0.2.86
+### Patch Changes
+- Bump `@thirdweb-dev/engine` to 3.0.3 for Engine API updates
+- Update compatibility with `@thirdweb-dev/thirdweb` v5.102.0📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## 0.2.86 | |
| ## 0.2.86 | |
| ### Patch Changes | |
| - Bump `@thirdweb-dev/engine` to 3.0.3 for Engine API updates | |
| - Update compatibility with `@thirdweb-dev/thirdweb` v5.102.0 |
🤖 Prompt for AI Agents
In packages/wagmi-adapter/CHANGELOG.md at lines 3 to 4, the version header for
0.2.86 is present but lacks any release notes or details. Add a concise summary
of the changes included in this release, such as dependency updates or
compatibility fixes. If there are no user-facing changes, add a note stating "No
user-facing changes" to inform consumers about the release status.
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.102.0
Minor Changes
#7190
861e623Thanks @joaquim-verges! - Enhanced Engine functionality with server wallet management, search transactions and batch transaction support:Added
Engine.createServerWallet()to create a new server wallet with a custom labelAdded
Engine.getServerWallets()to list all existing server walletsAdded
Engine.searchTransactions()to search for transactions by various filters (id, chainId, from address, etc.)Added
serverWallet.enqueueBatchTransaction()to enqueue multiple transactions in a single batchImproved server wallet transaction handling with better error reporting
Patch Changes
861e623]:@thirdweb-dev/engine@3.0.3
Patch Changes
861e623Thanks @joaquim-verges! - Updated to latest API@thirdweb-dev/wagmi-adapter@0.2.86
PR-Codex overview
This PR focuses on updating the versions of several packages and enhancing the
Enginefunctionality in thethirdweblibrary, particularly around server wallet management and transaction handling.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.101.2to5.102.0versioninpackages/engine/package.jsonfrom3.0.2to3.0.3versioninpackages/wagmi-adapter/package.jsonfrom0.2.85to0.2.86Engine:Engine.createServerWallet()to create a server walletEngine.getServerWallets()to list existing server walletsEngine.searchTransactions()for searching transactions with filtersserverWallet.enqueueBatchTransaction()to enqueue multiple transactionsSummary by CodeRabbit
New Features
Chores